[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for New uAPI drm properties for color management (rev2)

Patchwork patchwork at emeril.freedesktop.org
Fri Jun 18 09:47:51 UTC 2021 

== Series Details ==

Series: New uAPI drm properties for color management (rev2)
URL   : https://patchwork.freedesktop.org/series/91523/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
8a1dbc104f1d drm/amd/display: Remove unnecessary SIGNAL_TYPE_HDMI_TYPE_A check
-:32: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#32: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5356:
 	if (drm_mode_is_420_only(info, mode_in)
+			|| (drm_mode_is_420_also(info, mode_in) && aconnector->force_yuv420_output))

total: 0 errors, 0 warnings, 1 checks, 11 lines checked
a184c9f6c5f9 drm/amd/display: Add missing cases convert_dc_color_depth_into_bpc
5d445706107f drm/uAPI: Add "active bpc" as feedback channel for "max bpc" drm property
f27795b7edfc drm/amd/display: Add handling for new "active bpc" property
-:40: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#40: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9097:
+				drm_connector_set_active_bpc_property(connector,
+					convert_dc_color_depth_into_bpc(

-:40: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#40: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9097:
+					convert_dc_color_depth_into_bpc(

-:42: CHECK:BRACES: Unbalanced braces around else statement
#42: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9099:
+		} else

total: 0 errors, 0 warnings, 3 checks, 42 lines checked
d894e2d6d92c drm/i915/display: Add handling for new "active bpc" property
-:33: CHECK:BRACES: braces {} should be used on all arms of this statement
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:10917:
+		if (crtc) {
[...]
+		} else
[...]

-:38: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#38: FILE: drivers/gpu/drm/i915/display/intel_display.c:10922:
+			drm_connector_set_active_bpc_property(connector,
+				new_crtc_state->pipe_bpp / 3);

-:39: CHECK:BRACES: Unbalanced braces around else statement
#39: FILE: drivers/gpu/drm/i915/display/intel_display.c:10923:
+		} else

total: 0 errors, 0 warnings, 3 checks, 66 lines checked
01063e3e0973 drm/uAPI: Add "active color format" drm property as feedback for userspace
b3388b2b31a3 drm/amd/display: Add handling for new "active color format" property
-:20: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#20: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:6718:
+static int convert_dc_pixel_encoding_into_drm_color_format(

-:60: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#60: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9119:
+				drm_connector_set_active_color_format_property(connector,
+					convert_dc_pixel_encoding_into_drm_color_format(

-:60: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#60: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9119:
+					convert_dc_pixel_encoding_into_drm_color_format(

total: 0 errors, 0 warnings, 3 checks, 61 lines checked
d20d983e5c00 drm/i915/display: Add handling for new "active color format" property
-:44: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#44: FILE: drivers/gpu/drm/i915/display/intel_display.c:10939:
+			drm_connector_set_active_color_format_property(connector,
+				convert_intel_output_format_into_drm_color_format(

-:44: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#44: FILE: drivers/gpu/drm/i915/display/intel_display.c:10939:
+				convert_intel_output_format_into_drm_color_format(

total: 0 errors, 0 warnings, 2 checks, 64 lines checked
38cabfeae439 drm/uAPI: Add "active color range" drm property as feedback for userspace
34a60f410858 drm/amd/display: Add handling for new "active color range" property
-:63: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#63: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9150:
+				drm_connector_set_active_color_range_property(connector,
+					convert_dc_color_space_into_drm_mode_color_range(

-:63: CHECK:OPEN_ENDED_LINE: Lines should not end with a '('
#63: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:9150:
+					convert_dc_color_space_into_drm_mode_color_range(

total: 0 errors, 0 warnings, 2 checks, 65 lines checked
4a5eb1073840 drm/i915/display: Add handling for new "active color range" property
-:21: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#21: FILE: drivers/gpu/drm/i915/display/intel_display.c:10942:
+			drm_connector_set_active_color_range_property(connector,
+				new_crtc_state->limited_color_range ?

total: 0 errors, 0 warnings, 1 checks, 45 lines checked
c75e0d2c86bc drm/uAPI: Add "preferred color format" drm property as setting for userspace
7c574ffde4b2 drm/amd/display: Add handling for new "preferred color format" property
-:25: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#25: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5356:
+	if (connector_state
+			&& (connector_state->preferred_color_format == DRM_COLOR_FORMAT_YCRCB420

-:26: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#26: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5357:
+			&& (connector_state->preferred_color_format == DRM_COLOR_FORMAT_YCRCB420
+			|| aconnector->force_yuv420_output) && drm_mode_is_420(info, mode_in))

-:31: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#31: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5360:
+	else if (connector_state
+			&& connector_state->preferred_color_format == DRM_COLOR_FORMAT_YCRCB444

-:32: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#32: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5361:
+			&& connector_state->preferred_color_format == DRM_COLOR_FORMAT_YCRCB444
+			&& connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)

-:36: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#36: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5364:
+	else if (connector_state
+			&& connector_state->preferred_color_format == DRM_COLOR_FORMAT_RGB444

-:37: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#37: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5365:
+			&& connector_state->preferred_color_format == DRM_COLOR_FORMAT_RGB444
+			&& !drm_mode_is_420_only(info, mode_in))

-:48: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#48: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5376:
+		else if ((connector->display_info.color_formats & DRM_COLOR_FORMAT_YCRCB444)
+				&& stream->signal == SIGNAL_TYPE_HDMI_TYPE_A)

total: 0 errors, 0 warnings, 7 checks, 55 lines checked
7036e14723d4 drm/i915/display: Add handling for new "preferred color format" property
fb7489fcb966 drm/uAPI: Move "Broadcast RGB" property from driver specific to general context
0e59e4efe994 drm/i915/display: Use the general "Broadcast RGB" implementation
c085286ee017 drm/amd/display: Add handling for new "Broadcast RGB" property
-:32: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#32: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5272:
+			if (dc_crtc_timing->flags.Y_ONLY
+					|| preferred_color_range ==

-:41: CHECK:LOGICAL_CONTINUATIONS: Logical continuations should be on the previous line
#41: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:5280:
+			if (dc_crtc_timing->flags.Y_ONLY
+					|| preferred_color_range ==

total: 0 errors, 0 warnings, 2 checks, 67 lines checked

More information about the Intel-gfx mailing list