[Intel-gfx] [PATCH] drm/simple-helper: drm_gem_simple_display_pipe_prepare_fb as default
Sam Ravnborg
sam at ravnborg.org
Wed Jun 23 17:34:18 UTC 2021
Hi Daniel, looks good.
On Wed, Jun 23, 2021 at 06:24:56PM +0200, Daniel Vetter wrote:
> It's tedious to review this all the time, and my audit showed that
> arcpgu actually forgot to set this.
>
> Make this the default and stop worrying.
>
> Again I sprinkled WARN_ON_ONCE on top to make sure we don't have
> strange combinations of hooks: cleanup_fb without prepare_fb doesn't
> make sense, and since simpler drivers are all new they better be GEM
> based drivers.
>
> v2: Warn and bail when it's _not_ a GEM driver (Noralf)
>
> v3: It's neither ... nor, not not (Sam)
>
> Cc: Sam Ravnborg <sam at ravnborg.org>
> Cc: Noralf Trønnes <noralf at tronnes.org>
> Acked-by: Noralf Trønnes <noralf at tronnes.org>
> Signed-off-by: Daniel Vetter <daniel.vetter at intel.com>
> Cc: Maarten Lankhorst <maarten.lankhorst at linux.intel.com>
> Cc: Maxime Ripard <mripard at kernel.org>
> Cc: Thomas Zimmermann <tzimmermann at suse.de>
> Cc: David Airlie <airlied at linux.ie>
> Cc: Daniel Vetter <daniel at ffwll.ch>
Acked-by: Sam Ravnborg <sam at ravnborg.org>
More information about the Intel-gfx
mailing list