[Intel-gfx] [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs

[Gupta, Anshuman]

> -----Original Message-----
> From: AceLan Kao <acelan at gmail.com> On Behalf Of
> acelan.kao at canonical.com
> Sent: Wednesday, June 30, 2021 4:49 PM
> To: Gupta, Anshuman <anshuman.gupta at intel.com>; intel-
> gfx at lists.freedesktop.org
> Subject: Re: [v2] drm/i915: Tweaked Wa_14010685332 for all PCHs
> 
> > dispcnlunit1_cp_xosc_clkreq clock observed to be active on TGL-H
> > platform despite Wa_14010685332 original sequence, thus blocks entry
> > to deeper s0ix state.
> >
> > The Tweaked Wa_14010685332 sequence fixes this issue, therefore use
> > tweaked
> > Wa_14010685332 sequence for every PCH since PCH_CNP.
> >
> > v2:
> > - removed RKL from comment and simplified condition. [Rodrigo]
> >
> > Fixes: b896898c7369 ("drm/i915: Tweaked Wa_14010685332 for PCHs used
> > on
> > gen11 platforms") Cc: Matt Roper <matthew.d.roper at intel.com>
> > Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> > Cc: Imre Deak <imre.deak at intel.com>
> > Signed-off-by: Anshuman Gupta <anshuman.gupta at intel.com>
> > ---
> >
> >  .../drm/i915/display/intel_display_power.c    | 16 +++++++-------
> >  drivers/gpu/drm/i915/i915_irq.c               | 21 -------------------
> >  2 files changed, 8 insertions(+), 29 deletions(-)
> Hi,
> 
> I didn't see this patch shown in mainline kernel tree, nor in drm-tip, May I know
> what the patch's status now?
We have observed that this patch does not fix the issue on some platforms.
That is the reason patch is not merged yet.
Br,
Anshuman Gupta.
> 
>