[Intel-gfx] [PATCH 4/4] drm/i915/dg1: WA GPU hang at RCC

[Han, Zhen]

Yes, that's the case.
It has RCC related silicon issues in gen12-lp.
Followings are two consecutive GPU hangs we found in SG1 and DG1 linux which have no media compressible render target.
1. HSD-1508524297<https://hsdes.intel.com/appstore/article/>  [SG1][DG1] GPU hang in PIPECONTROL in running 120 ways of Android container with running pocket story HD apk.
--> The solution is disable RHWO optimization in default.
2. hsd-1508734716<https://hsdes.intel.com/appstore/article/> [DG1][Linux] GPU hang in PIPECONTROL(IPEHR:0x7a000004) with (PSS, RCPFE, RCC, WMFE) not done in running Monkey test
--> The solution is keeping RHWO optimization in when Render Target Resolve type is PARTIAL or FULL. The change will be in mesa code.

SV and RCC design team have further study and give the root cause explain the bug-eco HSD of 1508744258 - Hang due to deadlock created by RHWO scenario with RHWO optimization enabled<https://hsdes.intel.com/appstore/article/>.

BTW, recently, Windows team found similar GPU hangs in custom's TGL platform and need "disable RHWO" as the WA solution.  So it's a general issues in Gen12 (TGL and DG1).
*       14012336472 - [HP-TDC_IEC/HarryPotter]SIO1880260 Simple Solitaire UI show garbage when playing the game by finger.<https://hsdes.intel.com/appstore/article/>
*       18014955083 - [TGL] Sporadic pixel shader hang when alpha blending is enabled <https://hsdes.intel.com/appstore/article/>  (SV sighting)

Thanks
Han Zhen

-----Original Message-----
From: De Marchi, Lucas <lucas.demarchi at intel.com>
Sent: Wednesday, March 3, 2021 9:07 AM
To: intel-gfx at lists.freedesktop.org
Cc: Han, Zhen <zhen.han at intel.com>; Liu, Jianjun <jianjun.liu at intel.com>; Liu, Chuansheng <chuansheng.liu at intel.com>; Sripada, Radhakrishna <radhakrishna.sripada at intel.com>
Subject: [PATCH 4/4] drm/i915/dg1: WA GPU hang at RCC

From: Zhen Han <zhen.han at intel.com<mailto:zhen.han at intel.com>>

GPU hangs at RCC. According to Wa_14012131227 we shouldn't have a hang due to RHWO, but that is what we are observing, even without media compressible render target. Feedback from HW engineers is to leave RHWO disabled.

Cc: Jianjun Liu <Jianjun.liu at intel.com<mailto:Jianjun.liu at intel.com>>
Cc: Chuansheng Liu <chuansheng.liu at intel.com<mailto:chuansheng.liu at intel.com>>
Cc: Radhakrishna Sripada <radhakrishna.sripada at intel.com<mailto:radhakrishna.sripada at intel.com>>
Signed-off-by: Zhen Han <zhen.han at intel.com<mailto:zhen.han at intel.com>>
Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com<mailto:lucas.demarchi at intel.com>>
---
 drivers/gpu/drm/i915/gt/intel_workarounds.c | 11 +++++++++++
 1 file changed, 11 insertions(+)

diff --git a/drivers/gpu/drm/i915/gt/intel_workarounds.c b/drivers/gpu/drm/i915/gt/intel_workarounds.c
index e678fa8d2ab9..5235fb70a69a 100644
--- a/drivers/gpu/drm/i915/gt/intel_workarounds.c
+++ b/drivers/gpu/drm/i915/gt/intel_workarounds.c
@@ -739,6 +739,17 @@ static void dg1_ctx_workarounds_init(struct intel_engine_cs *engine,
               FF_MODE2,
               FF_MODE2_GS_TIMER_MASK,
               FF_MODE2_GS_TIMER_224, 0);
+
+       /*
+        * Wa_14012131227
+        *
+        * Although the WA is described as causing corruption when using media
+        * compressible render target, leaving RHWO enabled is also causing
+        * gpu hang when using multiple concurrent render and media workloads.
+        * Disable it completely for now.
+        */
+       wa_masked_en(wal, GEN7_COMMON_SLICE_CHICKEN1,
+                    GEN9_RHWO_OPTIMIZATION_DISABLE);
 }

 static void
--
2.30.1


-------------- next part --------------
An HTML attachment was scrubbed...
URL: <https://lists.freedesktop.org/archives/intel-gfx/attachments/20210303/dc6cc265/attachment.htm>