[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Remove obj->mm.lock! (rev16)

Patchwork patchwork at emeril.freedesktop.org
Thu Mar 11 14:27:04 UTC 2021 

== Series Details ==

Series: drm/i915: Remove obj->mm.lock! (rev16)
URL   : https://patchwork.freedesktop.org/series/82337/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
62d87d68daa6 drm/i915: Do not share hwsp across contexts any more, v7.
-:562: WARNING:CONSTANT_COMPARISON: Comparisons should place the constant on the right side of the test
#562: FILE: drivers/gpu/drm/i915/gt/intel_timeline.c:286:
+	if (TIMELINE_SEQNO_BYTES <= BIT(5) && (next_ofs & BIT(5)))

total: 0 errors, 1 warnings, 0 checks, 954 lines checked
45179357f4a3 drm/i915: Pin timeline map after first timeline pin, v3.
-:16: WARNING:TYPO_SPELLING: 'arithmatic' may be misspelled - perhaps 'arithmetic'?
#16: 
- Fix NULL + XX arithmatic, use casts. (kbuild)
                ^^^^^^^^^^

total: 0 errors, 1 warnings, 0 checks, 296 lines checked
05ca8fd3489b drm/i915: Move cmd parser pinning to execbuffer
c3e85904db1d drm/i915: Add missing -EDEADLK handling to execbuf pinning, v2.
-:59: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#59: FILE: drivers/gpu/drm/i915/gem/i915_gem_execbuffer.c:452:
+		err = i915_vma_pin_ww(vma, &eb->ww,
 					     entry->pad_to_size,

total: 0 errors, 0 warnings, 1 checks, 75 lines checked
d3c0d6934682 drm/i915: Ensure we hold the object mutex in pin correctly.
513ee4798499 drm/i915: Add gem object locking to madvise.
98108b44d022 drm/i915: Move HAS_STRUCT_PAGE to obj->flags
-:110: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#110: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.c:63:
+			  struct lock_class_key *key, unsigned flags)

-:133: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int' to bare use of 'unsigned'
#133: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:53:
+			  unsigned alloc_flags);

total: 0 errors, 2 warnings, 0 checks, 350 lines checked
3768448e58fc drm/i915: Rework struct phys attachment handling
94c02fbb4cec drm/i915: Convert i915_gem_object_attach_phys() to ww locking, v2.
2ff91be66b1e drm/i915: make lockdep slightly happier about execbuf.
4f5772ae4042 drm/i915: Disable userptr pread/pwrite support.
063d779f45a2 drm/i915: No longer allow exporting userptr through dma-buf
6cce6a791e3b drm/i915: Reject more ioctls for userptr, v2.
40c7ada6528a drm/i915: Reject UNSYNCHRONIZED for userptr, v2.
c006fd23ae00 drm/i915: Make compilation of userptr code depend on MMU_NOTIFIER.
b4e92512f008 drm/i915: Fix userptr so we do not have to worry about obj->mm.lock, v7.
-:332: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#332: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:605:
+static inline int i915_gem_object_userptr_submit_init(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:333: WARNING:LONG_LINE: line length of 121 exceeds 100 columns
#333: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:606:
+static inline int i915_gem_object_userptr_submit_done(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:334: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#334: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:607:
+static inline void i915_gem_object_userptr_submit_fini(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); }

-:335: WARNING:LONG_LINE: line length of 118 exceeds 100 columns
#335: FILE: drivers/gpu/drm/i915/gem/i915_gem_object.h:608:
+static inline int i915_gem_object_userptr_validate(struct drm_i915_gem_object *obj) { GEM_BUG_ON(1); return -ENODEV; }

-:394: WARNING:SPDX_LICENSE_TAG: Misplaced SPDX-License-Identifier tag - use line 1 instead
#394: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:2:
  * SPDX-License-Identifier: MIT

-:398: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#398: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:6:
+ *
+  * Based on amdgpu_mn, which bears the following notice:

-:399: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#399: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:7:
+  * Based on amdgpu_mn, which bears the following notice:
+ *

-:484: WARNING:LONG_LINE: line length of 106 exceeds 100 columns
#484: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:63:
+	struct drm_i915_gem_object *obj = container_of(mni, struct drm_i915_gem_object, userptr.notifier);

-:1172: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#1172: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:300:
+	pinned = ret = 0;

-:1187: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1187: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:315:
+	if (mmu_interval_read_retry(&obj->userptr.notifier,
+		!obj->userptr.page_ref ? notifier_seq :

-:1334: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
#1334: FILE: drivers/gpu/drm/i915/i915_drv.h:564:
+	spinlock_t notifier_lock;

total: 0 errors, 8 warnings, 3 checks, 1267 lines checked
3c7404bac792 drm/i915: Flatten obj->mm.lock
206f875cafc5 drm/i915: Populate logical context during first pin.
72e9bfd7ceea drm/i915: Make ring submission compatible with obj->mm.lock removal, v2.
598e9ba1dfed drm/i915: Handle ww locking in init_status_page
6bf1b9e277f3 drm/i915: Rework clflush to work correctly without obj->mm.lock.
01cd746af3c5 drm/i915: Pass ww ctx to intel_pin_to_display_plane
b2cecc1e4972 drm/i915: Add object locking to vm_fault_cpu
1092d212be31 drm/i915: Move pinning to inside engine_wa_list_verify()
-:72: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#72: FILE: drivers/gpu/drm/i915/gt/intel_workarounds.c:2215:
+	err = i915_vma_pin_ww(vma, &ww, 0, 0,
+			   i915_vma_is_ggtt(vma) ? PIN_GLOBAL : PIN_USER);

total: 0 errors, 0 warnings, 1 checks, 118 lines checked
95ab8d6067d0 drm/i915: Take reservation lock around i915_vma_pin.
5e0e47dd8939 drm/i915: Make lrc_init_wa_ctx compatible with ww locking, v3.
0234dc4ff4ff drm/i915: Make __engine_unpark() compatible with ww locking.
-:10: WARNING:REPEATED_WORD: Possible repeated word: 'many'
#10: 
many many places where rpm is used, I chose the safest option

total: 0 errors, 1 warnings, 0 checks, 16 lines checked
38250623370a drm/i915: Take obj lock around set_domain ioctl
-:85: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#85: FILE: drivers/gpu/drm/i915/gem/i915_gem_domain.c:518:
+		err = i915_gem_object_wait(obj,
+					  I915_WAIT_INTERRUPTIBLE |

total: 0 errors, 0 warnings, 1 checks, 74 lines checked
ab50d5ae3aa1 drm/i915: Defer pin calls in buffer pool until first use by caller.
95dd9a5b76ad drm/i915: Fix pread/pwrite to work with new locking rules.
-:32: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#32: 
deleted file mode 100644

total: 0 errors, 1 warnings, 0 checks, 349 lines checked
b84204b94870 drm/i915: Fix workarounds selftest, part 1
9dd394f55435 drm/i915: Prepare for obj->mm.lock removal, v2.
-:135: WARNING:FROM_SIGN_OFF_MISMATCH: From:/Signed-off-by: email address mismatch: 'From: "Thomas Hellström" <thomas.hellstrom at intel.com>' != 'Signed-off-by: Thomas Hellström <thomas.hellstrom at linux.intel.com>'

total: 0 errors, 1 warnings, 0 checks, 96 lines checked
594fb9bb3edf drm/i915: Add igt_spinner_pin() to allow for ww locking around spinner.
aac3d8e69b16 drm/i915: Add ww locking around vm_access()
856988996488 drm/i915: Increase ww locking for perf.
13463c86de73 drm/i915: Lock ww in ucode objects correctly
7bf1238f430a drm/i915: Add ww locking to dma-buf ops.
2f5f9bca3704 drm/i915: Add missing ww lock in intel_dsb_prepare.
60f82fd9a7c9 drm/i915: Fix ww locking in shmem_create_from_object
25ec5fbd2244 drm/i915: Use a single page table lock for each gtt.
-:112: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#112: FILE: drivers/gpu/drm/i915/gt/intel_gtt.c:85:
+		return i915_gem_object_lock(vm->scratch[0], ww);
+	} else {

total: 0 errors, 1 warnings, 0 checks, 154 lines checked
07742daa31f1 drm/i915/selftests: Prepare huge_pages testcases for obj->mm.lock removal.
a0edf1dedfcb drm/i915/selftests: Prepare client blit for obj->mm.lock removal.
c518b61f2828 drm/i915/selftests: Prepare coherency tests for obj->mm.lock removal.
f76bff23db43 drm/i915/selftests: Prepare context tests for obj->mm.lock removal.
1f422bb004d2 drm/i915/selftests: Prepare dma-buf tests for obj->mm.lock removal.
a2b35549e350 drm/i915/selftests: Prepare execbuf tests for obj->mm.lock removal.
1ad052fc5083 drm/i915/selftests: Prepare mman testcases for obj->mm.lock removal.
ad8e58bc1d77 drm/i915/selftests: Prepare object tests for obj->mm.lock removal.
78ac2ae0a6f3 drm/i915/selftests: Prepare object blit tests for obj->mm.lock removal.
c60227da1d5e drm/i915/selftests: Prepare igt_gem_utils for obj->mm.lock removal
ae02f93ac96e drm/i915/selftests: Prepare context selftest for obj->mm.lock removal
d4b60b619e09 drm/i915/selftests: Prepare hangcheck for obj->mm.lock removal
a46ab6927106 drm/i915/selftests: Prepare execlists and lrc selftests for obj->mm.lock removal
-:163: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#163: FILE: drivers/gpu/drm/i915/gt/selftest_lrc.c:1303:
+	lrc = i915_gem_object_pin_map_unlocked(ce->state->obj,
 				      i915_coherent_map_type(engine->i915));

total: 0 errors, 0 warnings, 1 checks, 130 lines checked
567f1fdb0fd3 drm/i915/selftests: Prepare mocs tests for obj->mm.lock removal
3e54a317b6a2 drm/i915/selftests: Prepare ring submission for obj->mm.lock removal
0d29694fa958 drm/i915/selftests: Prepare timeline tests for obj->mm.lock removal
3eba970a2562 drm/i915/selftests: Prepare i915_request tests for obj->mm.lock removal
b0a1c130a3e1 drm/i915/selftests: Prepare memory region tests for obj->mm.lock removal
bfc623e7aa5a drm/i915/selftests: Prepare cs engine tests for obj->mm.lock removal
eccf40ac6dff drm/i915/selftests: Prepare gtt tests for obj->mm.lock removal
82341525cb30 drm/i915: Finally remove obj->mm.lock.
b54702917508 drm/i915: Keep userpointer bindings if seqcount is unchanged, v2.
6c9553a14119 drm/i915: Move gt_revoke() slightly
6a04f7a4fb3d drm/i915: Add missing -EDEADLK path in execbuffer ggtt pinning.
c4bcee10e1ff drm/i915: Fix pin_map in scheduler selftests
-:7: WARNING:COMMIT_MESSAGE: Missing commit description - Add an appropriate one

total: 0 errors, 1 warnings, 0 checks, 8 lines checked
17e1f6f13463 drm/i915: Add ww parameter to get_pages() callback
2a3925c85678 drm/i915: Add ww context to prepare_(read/write)
-:6: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#6: 
This will allow us to explicitly pass the ww to pin_pages, when it starts taking it.

total: 0 errors, 1 warnings, 0 checks, 107 lines checked
01ec61981f44 drm/i915: Pass ww ctx to pin_map
-:456: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#456: FILE: drivers/gpu/drm/i915/i915_perf.c:1668:
+	batch = cs = i915_gem_object_pin_map(bo, &ww, I915_MAP_WB);

total: 0 errors, 0 warnings, 1 checks, 337 lines checked
df3000218c20 drm/i915: Pass ww ctx to i915_gem_object_pin_pages

More information about the Intel-gfx mailing list