[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Default request/fence expiry + watchdog

Patchwork patchwork at emeril.freedesktop.org
Fri Mar 12 16:22:11 UTC 2021


== Series Details ==

Series: Default request/fence expiry + watchdog
URL   : https://patchwork.freedesktop.org/series/87930/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
865f5ed6eec8 drm/i915: Individual request cancellation
-:256: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_inactive', this function's name, in a string
#256: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:660:
+		pr_err("%s: __cancel_inactive error %d\n", engine->name, err);

-:317: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_active', this function's name, in a string
#317: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:721:
+		pr_err("%s: __cancel_active error %d\n", engine->name, err);

-:388: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_active_chain', this function's name, in a string
#388: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:792:
+		pr_err("%s: __cancel_active_chain error %d\n",

-:438: WARNING:EMBEDDED_FUNCTION_NAME: Prefer using '"%s...", __func__' to using '__cancel_completed', this function's name, in a string
#438: FILE: drivers/gpu/drm/i915/selftests/i915_request.c:842:
+		pr_err("%s: __cancel_completed error %d\n", engine->name, err);

total: 0 errors, 4 warnings, 0 checks, 444 lines checked
5b101fa80277 drm/i915: Restrict sentinel requests further
c4f617682a6d drm/i915: Request watchdog infrastructure
-:197: WARNING:LONG_LINE_COMMENT: line length of 124 exceeds 100 columns
#197: FILE: drivers/gpu/drm/i915/i915_request.c:314:
+			       NSEC_PER_MSEC, /* FIXME check if it gives the "not sooner" guarantee or slack is both ways */

total: 0 errors, 1 warnings, 0 checks, 190 lines checked
9e458012bb44 drm/i915: Allow userspace to configure the watchdog
5d0b88dfca39 drm/i915: Fail too long user submissions by default
7f4fb6d644b5 drm/i915: Allow configuring default request expiry via modparam




More information about the Intel-gfx mailing list