[Intel-gfx] [PATCH v2 2/7] drm/i915: Remove dead signal level debugs

Ville Syrjala ville.syrjala at linux.intel.com
Thu Mar 18 16:10:10 UTC 2021


From: Ville Syrjälä <ville.syrjala at linux.intel.com>

If we ever get here with bogus signal levels we've messed
up somewhere earlier. Just use MISSIN_CASE().

Reviewed-by: Daniel Vetter <daniel.vetter at ffwll.ch>
Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
---
 drivers/gpu/drm/i915/display/intel_dp.c | 6 ++----
 1 file changed, 2 insertions(+), 4 deletions(-)

diff --git a/drivers/gpu/drm/i915/display/intel_dp.c b/drivers/gpu/drm/i915/display/intel_dp.c
index d1945bff6980..0ce96bd87a49 100644
--- a/drivers/gpu/drm/i915/display/intel_dp.c
+++ b/drivers/gpu/drm/i915/display/intel_dp.c
@@ -3310,8 +3310,7 @@ static u32 snb_cpu_edp_signal_levels(u8 train_set)
 	case DP_TRAIN_VOLTAGE_SWING_LEVEL_3 | DP_TRAIN_PRE_EMPH_LEVEL_0:
 		return EDP_LINK_TRAIN_800_1200MV_0DB_SNB_B;
 	default:
-		DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:"
-			      "0x%x\n", signal_levels);
+		MISSING_CASE(signal_levels);
 		return EDP_LINK_TRAIN_400_600MV_0DB_SNB_B;
 	}
 }
@@ -3362,8 +3361,7 @@ static u32 ivb_cpu_edp_signal_levels(u8 train_set)
 		return EDP_LINK_TRAIN_800MV_3_5DB_IVB;
 
 	default:
-		DRM_DEBUG_KMS("Unsupported voltage swing/pre-emphasis level:"
-			      "0x%x\n", signal_levels);
+		MISSING_CASE(signal_levels);
 		return EDP_LINK_TRAIN_500MV_0DB_IVB;
 	}
 }
-- 
2.26.2



More information about the Intel-gfx mailing list