[Intel-gfx] [PATCH v2 2/3] drm/i915/display: remove FIXME comment for intended feature

Jani Nikula jani.nikula at linux.intel.com
Tue Mar 23 10:14:46 UTC 2021


On Fri, 19 Mar 2021, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
> Direction on gen >= 9 was to stop using straps and rely on VBT
> indicating if the port is present or not. Remove FIXME comment since
> this will never be "fixed".
>

Reviewed-by: Jani Nikula <jani.nikula at intel.com>

> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 6 ------
>  1 file changed, 6 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index c793cbecfb3b..82471961e721 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -11683,15 +11683,9 @@ static void intel_setup_outputs(struct drm_i915_private *dev_priv)
>  
>  		icl_dsi_init(dev_priv);
>  	} else if (IS_GEN9_LP(dev_priv)) {
> -		/*
> -		 * FIXME: Broxton doesn't support port detection via the
> -		 * DDI_BUF_CTL_A or SFUSE_STRAP registers, find another way to
> -		 * detect the ports.
> -		 */
>  		intel_ddi_init(dev_priv, PORT_A);
>  		intel_ddi_init(dev_priv, PORT_B);
>  		intel_ddi_init(dev_priv, PORT_C);
> -
>  		vlv_dsi_init(dev_priv);
>  	} else if (HAS_DDI(dev_priv)) {
>  		int found;

-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list