[Intel-gfx] [PATCH 0/3] Pipe DMC Prep patches

Jani Nikula jani.nikula at linux.intel.com
Wed May 5 06:40:46 UTC 2021


On Mon, 03 May 2021, Jani Nikula <jani.nikula at linux.intel.com> wrote:
> On Wed, 28 Apr 2021, Anusha Srivatsa <anusha.srivatsa at intel.com> wrote:
>> This series adds the prep work needed before the
>> actual Pipe DMC implementation.
>
> When should we rename csr to dmc all over the place?

To elaborate, I think it's pretty confusing that we use both CSR and DMC
acronyms in code. There may be a distinction, but we don't respect that
in the usage. Sure, the spec mentions both, but I don't think we follow
the naming there either.

I think we should just rename all CSR references to DMC, including the
file name and the function and struct names.

I wonder if it would be better to do the renames first before starting
to build a lot of changes on top.

BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center


More information about the Intel-gfx mailing list