[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Expose HDMI properties to userspace

Patchwork patchwork at emeril.freedesktop.org
Thu May 6 08:26:38 UTC 2021


== Series Details ==

Series: drm/i915/display: Expose HDMI properties to userspace
URL   : https://patchwork.freedesktop.org/series/89833/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fed7f9fc21db drm/i915/display: Expose HDMI properties to userspace
-:48: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!new_blob"
#48: FILE: drivers/gpu/drm/i915/display/intel_atomic.c:113:
+		if (new_blob == NULL)

-:75: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#75: FILE: drivers/gpu/drm/i915/display/intel_connector.c:280:
+	if (prop == NULL) {

-:78: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!prop"
#78: FILE: drivers/gpu/drm/i915/display/intel_connector.c:283:
+		if (prop == NULL)

-:137: CHECK:BRACES: braces {} should be used on all arms of this statement
#137: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:775:
+	if (!intel_conn_state->hdmi_vendor_product_blob)
[...]
+	else {
[...]

-:139: CHECK:BRACES: Unbalanced braces around else statement
#139: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:777:
+	else {

-:143: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#143: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:781:
+			ret = hdmi_spd_infoframe_init(frame, hdmi_vp_info->vendor,
+				hdmi_vp_info->product);

total: 0 errors, 0 warnings, 6 checks, 126 lines checked




More information about the Intel-gfx mailing list