[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/display: Try YCbCr420 color when RGB fails

Patchwork patchwork at emeril.freedesktop.org
Thu May 6 17:35:01 UTC 2021


== Series Details ==

Series: drm/i915/display: Try YCbCr420 color when RGB fails
URL   : https://patchwork.freedesktop.org/series/89842/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
00bf5b4bbe7e drm/i915/display: New function to avoid duplicate code in upcomming commits
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
Moves some checks that later will be performed 2 times to an own fuction. This

-:7: WARNING:TYPO_SPELLING: 'fuction' may be misspelled - perhaps 'function'?
#7: 
Moves some checks that later will be performed 2 times to an own fuction. This
                                                                 ^^^^^^^

total: 0 errors, 2 warnings, 0 checks, 53 lines checked
6cff290a93e1 drm/i915/display: Restructure output format computation for better expandability
-:7: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#7: 
Couples the decission between RGB and YCbCr420 mode and the check if the port

-:58: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#58: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2110:
+static int intel_hdmi_compute_output_format(struct intel_encoder *encoder,
+				     struct intel_crtc_state *crtc_state,

-:68: CHECK:BRACES: braces {} should be used on all arms of this statement
#68: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2120:
+	if (connector->ycbcr_420_allowed && ycbcr_420_only)
[...]
+	else {
[...]

-:70: CHECK:BRACES: Unbalanced braces around else statement
#70: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2122:
+	else {

total: 0 errors, 1 warnings, 3 checks, 92 lines checked
fa1ae5bd837f drm/i915/display: Use YCbCr420 as fallback when RGB fails
-:48: WARNING:LONG_LINE: line length of 125 exceeds 100 columns
#48: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1924:
+		if (ycbcr_420_only || !connector->ycbcr_420_allowed || !drm_mode_is_420_also(&connector->display_info, mode))

-:65: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#65: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:2140:
+		if (crtc_state->output_format != INTEL_OUTPUT_FORMAT_YCBCR420 &&
+				connector->ycbcr_420_allowed &&

total: 0 errors, 1 warnings, 1 checks, 44 lines checked




More information about the Intel-gfx mailing list