[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR
Patchwork
patchwork at emeril.freedesktop.org
Fri May 14 23:41:43 UTC 2021
== Series Details ==
Series: series starting with [v2,1/4] drm/i915/display: Fix fastsets involving PSR
URL : https://patchwork.freedesktop.org/series/90184/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
f2ee45fe2883 drm/i915/display: Fix fastsets involving PSR
9b3671205d77 drm/i915/display: Allow fastsets when DP_SDP_VSC infoframe do not match with PSR enabled
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'name' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+ if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+ pipe_config_mismatch(fastset, crtc, __stringify(name), \
+ "(expected 0x%08x, found 0x%08x)", \
+ current_config->name & (mask), \
+ pipe_config->name & (mask)); \
+ ret = false; \
+ } \
+} while (0)
-:33: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'name' may be better as '(name)' to avoid precedence issues
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+ if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+ pipe_config_mismatch(fastset, crtc, __stringify(name), \
+ "(expected 0x%08x, found 0x%08x)", \
+ current_config->name & (mask), \
+ pipe_config->name & (mask)); \
+ ret = false; \
+ } \
+} while (0)
-:33: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'mask' - possible side-effects?
#33: FILE: drivers/gpu/drm/i915/display/intel_display.c:8263:
+#define PIPE_CONF_CHECK_X_WITH_MASK(name, mask) do { \
+ if ((current_config->name & (mask)) != (pipe_config->name & (mask))) { \
+ pipe_config_mismatch(fastset, crtc, __stringify(name), \
+ "(expected 0x%08x, found 0x%08x)", \
+ current_config->name & (mask), \
+ pipe_config->name & (mask)); \
+ ret = false; \
+ } \
+} while (0)
total: 0 errors, 0 warnings, 3 checks, 29 lines checked
6c94b1f31bee drm/i915/display: Nuke has_infoframe
bc53eeffc17b drm/i915/display: Drop FIXME about turn off infoframes
More information about the Intel-gfx
mailing list