[Intel-gfx] [PATCH] drm/i915: Fix a possible use of uninitialized variable in remap_io_sg()

Souza, Jose jose.souza at intel.com
Sat May 15 00:23:04 UTC 2021


On Fri, 2021-05-14 at 07:49 +0200, Christoph Hellwig wrote:
> On Thu, May 13, 2021 at 04:28:41PM -0700, José Roberto de Souza wrote:
> > If the do while loop breaks in 'if (!sg_dma_len(sgl))' in the first
> > iteration, err is uninitialized causing a wrong call to zap_vma_ptes().
> 
> But scatterlist must have at least one valid segment.  So while the
> patch looks ok, please clearly mark that this is a false positive from
> the static checker in the commit log.

No static checker mentioned but yes it was caught by one.
Anyways better have this change and avoid possible reports from other static analyzers.

Can I add your Reviewed-by?

thanks



More information about the Intel-gfx mailing list