[Intel-gfx] [PATCH] drm/i915/display: fix typo when returning table

Srivatsa, Anusha anusha.srivatsa at intel.com
Fri May 21 16:58:32 UTC 2021


Reviewed-by: Anusha Srivatsa <anusha.srivatsa at intel.com>

> -----Original Message-----
> From: De Marchi, Lucas <lucas.demarchi at intel.com>
> Sent: Thursday, May 20, 2021 5:52 PM
> To: intel-gfx at lists.freedesktop.org
> Cc: Srivatsa, Anusha <anusha.srivatsa at intel.com>
> Subject: [PATCH] drm/i915/display: fix typo when returning table
> 
> Fix table returned when port_clock > 270000:
> 
> 	drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c:752:47: error:
> variable 'adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3' is not needed and will not
> be emitted [-Werror,-Wunneeded-internal-declaration]
> 	static const struct tgl_dkl_phy_ddi_buf_trans
> adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3[] = {
> 
> Initial version of the patch had it in a single table, but on second version the
> table got split, but we continued to reference just one of them.
> 
> Fixes: ca962882268a ("drm/i915/adl_p: Define and use ADL-P specific DP
> translation tables")
> Reported-by: kernel test robot <lkp at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> index ce5d5d13b7c1..8bfd00f49f2a 100644
> --- a/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> +++ b/drivers/gpu/drm/i915/display/intel_ddi_buf_trans.c
> @@ -1383,7 +1383,7 @@ adlp_get_dkl_buf_trans_dp(struct intel_encoder
> *encoder,  {
>  	if (crtc_state->port_clock > 270000) {
>  		*n_entries =
> ARRAY_SIZE(adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3);
> -		return adlp_dkl_phy_dp_ddi_trans_hbr;
> +		return adlp_dkl_phy_dp_ddi_trans_hbr2_hbr3;
>  	}
> 
>  	*n_entries = ARRAY_SIZE(adlp_dkl_phy_dp_ddi_trans_hbr);
> --
> 2.31.1



More information about the Intel-gfx mailing list