[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for dma-buf: Add an API for exporting sync files (v10)
Patchwork
patchwork at emeril.freedesktop.org
Mon May 24 22:30:52 UTC 2021
== Series Details ==
Series: dma-buf: Add an API for exporting sync files (v10)
URL : https://patchwork.freedesktop.org/series/90491/
State : warning
== Summary ==
$ dim checkpatch origin/drm-tip
24b0f0b1996a dma-buf: add dma_fence_array_for_each (v2)
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'fence' - possible side-effects?
#73: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head) \
+ for (index = 0, fence = dma_fence_array_first(head); fence; \
+ ++(index), fence = dma_fence_array_next(head, index))
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'index' - possible side-effects?
#73: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head) \
+ for (index = 0, fence = dma_fence_array_first(head); fence; \
+ ++(index), fence = dma_fence_array_next(head, index))
-:73: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'head' - possible side-effects?
#73: FILE: include/linux/dma-fence-array.h:86:
+#define dma_fence_array_for_each(fence, index, head) \
+ for (index = 0, fence = dma_fence_array_first(head); fence; \
+ ++(index), fence = dma_fence_array_next(head, index))
-:88: ERROR:NO_AUTHOR_SIGN_OFF: Missing Signed-off-by: line by nominal patch author '"Christian König" <ckoenig.leichtzumerken at gmail.com>'
total: 1 errors, 0 warnings, 3 checks, 57 lines checked
0087839c7fb5 dma-buf: Rename dma_resv helpers from _rcu to _unlocked
-:24: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#24: FILE: drivers/dma-buf/dma-buf.c:1151:
+ ret = dma_resv_wait_timeout_unlocked(resv, write, true,
MAX_SCHEDULE_TIMEOUT);
-:50: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#50: FILE: drivers/dma-buf/dma-resv.c:434:
+ unsigned *pshared_count,
-:124: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#124: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_display.c:207:
+ r = dma_resv_get_fences_unlocked(new_abo->tbo.base.resv, &work->excl,
&work->shared_count,
-:150: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#150: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_gem.c:475:
+ ret = dma_resv_wait_timeout_unlocked(robj->tbo.base.resv, true, true,
timeout);
-:172: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#172: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_ids.c:160:
+ dma_resv_wait_timeout_unlocked(resv, true, false,
MAX_SCHEDULE_TIMEOUT);
-:185: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#185: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c:79:
+ r = dma_resv_wait_timeout_unlocked(bo->tbo.base.resv, true, false,
MAX_SCHEDULE_TIMEOUT);
-:198: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#198: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_object.c:760:
+ r = dma_resv_wait_timeout_unlocked(bo->tbo.base.resv, false, false,
MAX_SCHEDULE_TIMEOUT);
-:211: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#211: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_uvd.c:1130:
+ r = dma_resv_wait_timeout_unlocked(bo->tbo.base.resv,
true, false,
-:224: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#224: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2026:
+ r = dma_resv_get_fences_unlocked(resv, &excl,
&shared_count, &shared);
-:231: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#231: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2032:
+ dma_resv_wait_timeout_unlocked(resv, true, false,
MAX_SCHEDULE_TIMEOUT);
-:249: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#249: FILE: drivers/gpu/drm/amd/amdgpu/amdgpu_vm.c:2824:
+ timeout = dma_resv_wait_timeout_unlocked(vm->root.base.bo->tbo.base.resv,
true, true, timeout);
-:262: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#262: FILE: drivers/gpu/drm/amd/display/amdgpu_dm/amdgpu_dm.c:8404:
+ r = dma_resv_wait_timeout_unlocked(abo->tbo.base.resv, true,
false,
-:275: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#275: FILE: drivers/gpu/drm/drm_gem.c:774:
+ ret = dma_resv_wait_timeout_unlocked(obj->resv, wait_all,
true, timeout);
-:290: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#290: FILE: drivers/gpu/drm/drm_gem.c:1384:
+ ret = dma_resv_get_fences_unlocked(obj->resv, NULL,
&fence_count, &fences);
-:316: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#316: FILE: drivers/gpu/drm/etnaviv/etnaviv_gem.c:394:
+ if (!dma_resv_test_signaled_unlocked(obj->resv,
write))
-:323: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#323: FILE: drivers/gpu/drm/etnaviv/etnaviv_gem.c:400:
+ ret = dma_resv_wait_timeout_unlocked(obj->resv,
write, true, remain);
-:336: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#336: FILE: drivers/gpu/drm/etnaviv/etnaviv_gem_submit.c:193:
+ ret = dma_resv_get_fences_unlocked(robj, &bo->excl,
&bo->nr_shared,
-:421: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#421: FILE: drivers/gpu/drm/i915/gem/i915_gem_userptr.c:89:
+ r = dma_resv_wait_timeout_unlocked(obj->base.resv, true, false,
MAX_SCHEDULE_TIMEOUT);
-:476: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#476: FILE: drivers/gpu/drm/i915/i915_request.c:1598:
+ ret = dma_resv_get_fences_unlocked(obj->base.resv,
&excl, &count, &shared);
-:520: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#520: FILE: drivers/gpu/drm/msm/msm_gem.c:919:
+ ret = dma_resv_wait_timeout_unlocked(obj->resv, write,
true, remain);
-:546: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#546: FILE: drivers/gpu/drm/nouveau/nouveau_gem.c:932:
+ lret = dma_resv_wait_timeout_unlocked(nvbo->bo.base.resv, write, true,
no_wait ? 0 : 30 * HZ);
-:559: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#559: FILE: drivers/gpu/drm/panfrost/panfrost_drv.c:315:
+ ret = dma_resv_wait_timeout_unlocked(gem_obj->resv, true,
true, timeout);
-:616: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#616: FILE: drivers/gpu/drm/radeon/radeon_mn.c:70:
+ r = dma_resv_wait_timeout_unlocked(bo->tbo.base.resv, true, false,
MAX_SCHEDULE_TIMEOUT);
-:638: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#638: FILE: drivers/gpu/drm/ttm/ttm_bo.c:310:
+ lret = dma_resv_wait_timeout_unlocked(resv, true, interruptible,
30 * HZ);
-:647: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#647: FILE: drivers/gpu/drm/ttm/ttm_bo.c:413:
+ dma_resv_wait_timeout_unlocked(bo->base.resv, true, false,
30 * HZ);
-:672: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#672: FILE: drivers/gpu/drm/ttm/ttm_bo.c:1128:
+ timeout = dma_resv_wait_timeout_unlocked(bo->base.resv, true,
interruptible, timeout);
-:685: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#685: FILE: drivers/gpu/drm/vgem/vgem_fence.c:155:
+ if (!dma_resv_test_signaled_unlocked(resv,
arg->flags & VGEM_FENCE_WRITE)) {
-:701: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#701: FILE: drivers/gpu/drm/virtio/virtgpu_ioctl.c:457:
+ ret = dma_resv_wait_timeout_unlocked(obj->resv, true, true,
timeout);
-:749: WARNING:UNSPECIFIED_INT: Prefer 'unsigned int *' to bare use of 'unsigned *'
#749: FILE: include/linux/dma-resv.h:283:
+ unsigned *pshared_count,
total: 0 errors, 2 warnings, 27 checks, 545 lines checked
2ee8affbae32 dma-buf: add dma_resv_get_singleton_unlocked (v4)
-:61: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#61: FILE: drivers/dma-buf/dma-resv.c:55:
+#define dma_fence_deep_dive_for_each(fence, chain, index, head) \
+ dma_fence_chain_for_each(chain, head) \
+ dma_fence_array_for_each(fence, index, chain)
-:61: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'chain' - possible side-effects?
#61: FILE: drivers/dma-buf/dma-resv.c:55:
+#define dma_fence_deep_dive_for_each(fence, chain, index, head) \
+ dma_fence_chain_for_each(chain, head) \
+ dma_fence_array_for_each(fence, index, chain)
-:116: ERROR:POINTER_LOCATION: "(foo*)" should be "(foo *)"
#116: FILE: drivers/dma-buf/dma-resv.c:571:
+ fences = kmalloc_array(num_fences, sizeof(struct dma_fence*),
total: 2 errors, 0 warnings, 1 checks, 119 lines checked
c3099b106cdd dma-buf: Add an API for exporting sync files (v9)
-:193: WARNING:REPEATED_WORD: Possible repeated word: 'file'
#193: FILE: include/uapi/linux/dma-buf.h:59:
+ /** @fd: Sync file file descriptor */
total: 0 errors, 1 warnings, 0 checks, 117 lines checked
344e59afaa4d RFC: dma-buf: Add an extra fence to dma_resv_get_singleton_unlocked
cf5c4e9b68fe RFC: dma-buf: Add an API for importing sync files (v6)
More information about the Intel-gfx
mailing list