[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Catchup with a few dropped patches (rev2)

Patchwork patchwork at emeril.freedesktop.org
Wed May 26 20:19:23 UTC 2021


== Series Details ==

Series: Catchup with a few dropped patches (rev2)
URL   : https://patchwork.freedesktop.org/series/90611/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
06eaaa77f454 drm/i915: Take rcu_read_lock for querying fence's driver/timeline names
699c8e356b0c drm/i915: Remove notion of GEM from i915_gem_shrinker_taints_mutex
794fd65790d7 drm/i915: Lift marking a lock as used to utils
0381b2ec34da drm/i915: Wrap cmpxchg64 with try_cmpxchg64() helper
-:25: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ptr' - possible side-effects?
#25: FILE: drivers/gpu/drm/i915/i915_utils.h:482:
+#define try_cmpxchg64(_ptr, _pold, _new)				\
+({									\
+	__typeof__(_ptr) _old = (__typeof__(_ptr))(_pold);		\
+	__typeof__(*(_ptr)) __old = *_old;				\
+	__typeof__(*(_ptr)) __cur = cmpxchg64(_ptr, __old, _new);	\
+	bool success = __cur == __old;					\
+	if (unlikely(!success))						\
+		*_old = __cur;						\
+	likely(success);						\
+})

-:42: CHECK:MACRO_ARG_REUSE: Macro argument reuse '_ptr' - possible side-effects?
#42: FILE: drivers/gpu/drm/i915/i915_utils.h:499:
+#define xchg64(_ptr, _new)						\
+({									\
+	__typeof__(_ptr) __ptr = (_ptr);				\
+	__typeof__(*(_ptr)) __old = *__ptr;				\
+	while (!try_cmpxchg64(__ptr, &__old, (_new)))			\
+		;							\
+	__old;								\
+})

total: 0 errors, 0 warnings, 2 checks, 36 lines checked
4c11f7a7ba2a drm/i915/selftests: Set cache status for huge_gem_object
78904915722c drm/i915/selftests: Use a coherent map to setup scratch batch buffers
4b1c2e4e65db drm/i915/selftests: Replace the unbounded set-domain with an explicit wait
b572875c1081 drm/i915/selftests: Remove redundant set-to-gtt-domain
9ac234560778 drm/i915/selftests: Replace unbound set-domain waits with explicit timeouts
cd286f3a5c04 drm/i915/selftests: Replace an unbounded set-domain wait with a timeout
bbfac81d2ec6 drm/i915/selftests: Remove redundant set-to-gtt-domain before batch submission
a26743a5500b drm/i915/gem: Manage all set-domain waits explicitly




More information about the Intel-gfx mailing list