[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Non-interface changing GuC CTBs updates (rev2)

[John Harrison]

On 5/25/2021 23:42, Patchwork wrote:
> == Series Details ==
>
> Series: Non-interface changing GuC CTBs updates (rev2)
> URL   : https://patchwork.freedesktop.org/series/90552/
> State : warning
>
> == Summary ==
>
> $ dim checkpatch origin/drm-tip
> 6b6bffd59ced drm/i915/guc: skip disabling CTBs before sanitizing the GuC
> 3f9bbaddbf9d drm/i915/guc: use probe_error log for CT enablement failure
> 866285dad8d0 drm/i915/guc: enable only the user interrupt when using GuC submission
> eafc57f85f6f drm/i915/guc: Remove sample_forcewake h2g action
> cb62a7f50e3b drm/i915/guc: Keep strict GuC ABI definitions
> -:18: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
> #18:
> new file mode 100644
>
> total: 0 errors, 1 warnings, 0 checks, 476 lines checked
> 28e9b20a7873 drm/i915/guc: Drop guc->interrupts.enabled
> 190975af8c9f drm/i915/guc: Stop using fence/status from CTB descriptor
> 15a068ac5b1e drm/i915: Promote ptrdiff() to i915_utils.h
> e3a6d58106c2 drm/i915/guc: Only rely on own CTB size
> aaa8781a008e drm/i915/guc: Don't repeat CTB layout calculations
> b065023c038e drm/i915/guc: Replace CTB array with explicit members
> 9f1ec21626ae drm/i915/guc: Update sizes of CTB buffers
> 7a0e05be601b drm/i915/guc: Relax CTB response timeout
> 11573d2c3987 drm/i915/guc: Start protecting access to CTB descriptors
> -:87: CHECK:UNCOMMENTED_DEFINITION: spinlock_t definition without comment
> #87: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.h:36:
> +	spinlock_t lock;
>
> total: 0 errors, 0 warnings, 1 checks, 61 lines checked
> f32e4faa422e drm/i915/guc: Ensure H2G buffer updates visible before tail update
> -:23: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
> #23: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:331:
> +static void write_barrier(struct intel_guc_ct *ct) {
>
> -:31: WARNING:MEMORY_BARRIER: memory barrier without comment
> #31: FILE: drivers/gpu/drm/i915/gt/uc/intel_guc_ct.c:339:
> +		wmb();
These three warnings should be fixed.

John.

> total: 1 errors, 1 warnings, 0 checks, 30 lines checked
> 6feab437948e drm/i915/guc: Stop using mutex while sending CTB messages
> a44bbeef3e75 drm/i915/guc: Don't receive all G2H messages in irq handler
> 41650b9fd9e5 drm/i915/guc: Always copy CT message to new allocation
>
>
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx