[Intel-gfx] [PATCH] drm/i915/display: Add support of MOD_Y_TILED during fb init

[Ville Syrjälä]

On Mon, May 31, 2021 at 07:32:17PM +0800, Sodhi, Vunny wrote:
> Adding Y_TILED modifier which is needed to support DRM_FORMAT_NV12
> during framebuffer initialization.
> 
> Signed-off-by: Sodhi, Vunny <vunny.sodhi at intel.com>
> ---
>  drivers/gpu/drm/i915/display/intel_display.c | 4 +++-
>  1 file changed, 3 insertions(+), 1 deletion(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index caf0414..a9b1b62 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -11610,8 +11610,10 @@ static int intel_framebuffer_init(struct intel_framebuffer *intel_fb,
>  		if (tiling == I915_TILING_X) {
>  			mode_cmd->modifier[0] = I915_FORMAT_MOD_X_TILED;
>  		} else if (tiling == I915_TILING_Y) {
> +			mode_cmd->modifier[0] = I915_FORMAT_MOD_Y_TILED;
> +		} else {

This is just the legacy bo tiling->modifier path, which is not needed by
any old userspace, and all modern userspace should just use modifiers.

>  			drm_dbg_kms(&dev_priv->drm,
> -				    "No Y tiling for legacy addfb\n");
> +				    "Unsupported tiling for legacy addfb\n");
>  			goto err;
>  		}
>  	}
> -- 
> 2.7.4
> 
> _______________________________________________
> Intel-gfx mailing list
> Intel-gfx at lists.freedesktop.org
> https://lists.freedesktop.org/mailman/listinfo/intel-gfx

-- 
Ville Syrjälä
Intel