[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev3)

Patchwork patchwork at emeril.freedesktop.org
Fri Nov 5 03:20:52 UTC 2021 

== Series Details ==

Series: drm/hdcp: Pull HDCP auth/exchange/check into helpers (rev3)
URL   : https://patchwork.freedesktop.org/series/94712/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
69ba418e519d drm/hdcp: Add drm_hdcp_atomic_check()
-:11: WARNING:BAD_SIGN_OFF: Duplicate signature
#11: 
Acked-by: Jani Nikula <jani.nikula at intel.com>

-:88: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#88: FILE: drivers/gpu/drm/drm_hdcp.c:464:
+	/*
+	* Fix the HDCP uapi content protection state in case of modeset.

total: 0 errors, 2 warnings, 0 checks, 185 lines checked
0d2bd67b1ce9 drm/hdcp: Avoid changing crtc state in hdcp atomic check
ffc9a1202e45 drm/hdcp: Update property value on content type and user changes
a88b6e8ec8e8 drm/hdcp: Expand HDCP helper library for enable/disable/check
-:77: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#77: FILE: drivers/gpu/drm/drm_hdcp.c:523:
+	struct mutex mutex;

-:78: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#78: FILE: drivers/gpu/drm/drm_hdcp.c:524:
+	struct mutex *driver_mutex;

-:220: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#220: FILE: drivers/gpu/drm/drm_hdcp.c:666:
+static int drm_hdcp_remote_dpcd_write(struct drm_dp_aux *aux,
+				     unsigned int offset, u8 *value,

-:364: WARNING:LINE_SPACING: Missing a blank line after declarations
#364: FILE: drivers/gpu/drm/drm_hdcp.c:810:
+		size_t len = min(num_downstream - i, 3) * DRM_HDCP_KSV_LEN;
+		ret = drm_hdcp_remote_dpcd_read(data->aux, DP_AUX_HDCP_KSV_FIFO,

-:451: WARNING:TYPO_SPELLING: 'atleast' may be misspelled - perhaps 'at least'?
#451: FILE: drivers/gpu/drm/drm_hdcp.c:897:
+	 * V prime atleast twice.
 	           ^^^^^^^

-:521: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#521: FILE: drivers/gpu/drm/drm_hdcp.c:967:
+		ret = drm_hdcp_remote_write(data, data->hdcp1_lut->an, an.bytes,
+					DRM_HDCP_AN_LEN);

-:528: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#528: FILE: drivers/gpu/drm/drm_hdcp.c:974:
+		ret = drm_hdcp_remote_write(data, data->hdcp1_lut->aksv, aksv.bytes,
+					DRM_HDCP_KSV_LEN);

-:608: WARNING:LINE_SPACING: Missing a blank line after declarations
#608: FILE: drivers/gpu/drm/drm_hdcp.c:1054:
+		u8 val;
+		ret = read_poll_timeout(drm_hdcp_remote_dpcd_read, ret,

-:702: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "data->driver_mutex"
#702: FILE: drivers/gpu/drm/drm_hdcp.c:1148:
+	drm_WARN_ON(dev, data->driver_mutex != NULL);

-:852: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#852: FILE: drivers/gpu/drm/drm_hdcp.c:1298:
+			drm_hdcp_update_value(data, DRM_MODE_CONTENT_PROTECTION_DESIRED,
+					true);

-:908: WARNING:LINE_SPACING: Missing a blank line after declarations
#908: FILE: drivers/gpu/drm/drm_hdcp.c:1354:
+		u8 bstatus;
+		ret = drm_hdcp_remote_dpcd_read(data->aux, DP_AUX_HDCP_BSTATUS,

-:919: ERROR:SPACING: space required after that ',' (ctx:VxV)
#919: FILE: drivers/gpu/drm/drm_hdcp.c:1365:
+			drm_err(dev,"Ri' mismatch, check failed (%d)\n", ret);
 			           ^

-:1046: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#1046: FILE: drivers/gpu/drm/drm_hdcp.c:1492:
+	ret = drm_connector_attach_content_protection_property(connector,
+			attach_content_type_property);

-:1067: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#1067: FILE: drivers/gpu/drm/drm_hdcp.c:1513:
+ * HDCP helper data. Ownership of the underlaying memory is transfered to the
                                                             ^^^^^^^^^^

-:1105: WARNING:TYPO_SPELLING: 'transfered' may be misspelled - perhaps 'transferred'?
#1105: FILE: drivers/gpu/drm/drm_hdcp.c:1551:
+ * helper data. Ownership of the underlaying memory is transfered to the caller
                                                        ^^^^^^^^^^

-:1195: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#1195: FILE: include/drm/drm_hdcp.h:305:
+};
+struct drm_hdcp_an {

-:1387: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#1387: FILE: include/drm/drm_hdcp.h:498:
+				   struct mutex *driver_mutex);

total: 1 errors, 6 warnings, 10 checks, 1333 lines checked
5fb799565d46 drm/i915/hdcp: Consolidate HDCP setup/state cache
be2303dbd2c0 drm/i915/hdcp: Retain hdcp_capable return codes
6ad020fc723b drm/i915/hdcp: Use HDCP helpers for i915
-:69: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#69: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3041:
+		drm_hdcp_helper_atomic_commit(connector->hdcp_helper_data,
+					&state->base,

-:84: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#84: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:3098:
+		drm_hdcp_helper_atomic_commit(connector->hdcp_helper_data,
+					&state->base,

-:527: WARNING:BLOCK_COMMENT_STYLE: Block comments should align the * on each line
#527: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:567:
+	 * all connectors in MST topology.
+	*/

-:542: ERROR:CODE_INDENT: code indent should use tabs where possible
#542: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:611:
+^I^I^I          struct intel_connector *connector)$

-:605: CHECK:LINE_SPACING: Please don't use multiple blank lines
#605: FILE: drivers/gpu/drm/i915/display/intel_dp_hdcp.c:675:
+
+

-:675: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#675: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:366:
+		drm_hdcp_helper_atomic_commit(connector->hdcp_helper_data,
+					&state->base,

-:700: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#700: FILE: drivers/gpu/drm/i915/display/intel_dp_mst.c:585:
+		drm_hdcp_helper_atomic_commit(connector->hdcp_helper_data,
+					&state->base,

-:1973: CHECK:LINE_SPACING: Please don't use multiple blank lines
#1973: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1341:
+
+

-:2173: ERROR:CODE_INDENT: code indent should use tabs where possible
#2173: FILE: drivers/gpu/drm/i915/display/intel_hdmi.c:1601:
+^I^I^I        struct intel_connector *connector)$

total: 2 errors, 1 warnings, 6 checks, 2174 lines checked
e80794f67175 drm/msm/dpu_kms: Re-order dpu includes
179fce65d4fc drm/msm/dpu: Remove useless checks in dpu_encoder
6d55d3811064 drm/msm/dpu: Remove encoder->enable() hack
6c96cef3cc5d drm/msm/dp: Re-order dp_audio_put in deinit_sub_modules
dd447b99f295 dt-bindings: msm/dp: Add bindings for HDCP registers
d3aa26876114 arm64: dts: qcom: sc7180: Add support for HDCP in dp-controller
bc9858203ba6 drm/msm: Implement HDCP 1.x using the new drm HDCP helpers
-:131: WARNING:EXPORTED_WORLD_WRITABLE: Exporting world writable files is usually an error. Consider more restrictive permissions.
#131: FILE: drivers/gpu/drm/msm/dp/dp_debug.c:269:
+	debugfs_create_file("msm_dp_hdcp_key", 0222,

-:131: ERROR:EXPORTED_WORLD_WRITABLE: Exporting writable files is usually an error. Consider more restrictive permissions.
#131: FILE: drivers/gpu/drm/msm/dp/dp_debug.c:269:
+	debugfs_create_file("msm_dp_hdcp_key", 0222,
+			minor->debugfs_root,
+			debug, &dp_hdcp_key_fops);
-:132: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#132: FILE: drivers/gpu/drm/msm/dp/dp_debug.c:270:
+	debugfs_create_file("msm_dp_hdcp_key", 0222,
+			minor->debugfs_root,

-:347: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#347: FILE: drivers/gpu/drm/msm/dp/dp_drm.c:22:
+};
+#define to_dp_connector_state(x) container_of(x, struct dp_connector_state, base)

-:453: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#453: 
new file mode 100644

-:492: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#492: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:35:
+#define  DP_HDCP_KEY_MSB(x) ^I^I^I(DP_HDCP_KEY_BASE + (x * 8))$

-:492: CHECK:MACRO_ARG_PRECEDENCE: Macro argument 'x' may be better as '(x)' to avoid precedence issues
#492: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:35:
+#define  DP_HDCP_KEY_MSB(x) 			(DP_HDCP_KEY_BASE + (x * 8))

-:493: WARNING:SPACE_BEFORE_TAB: please, no space before tabs
#493: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:36:
+#define  DP_HDCP_KEY_LSB(x) ^I^I^I(DP_HDCP_KEY_MSB(x) + 4)$

-:535: CHECK:UNCOMMENTED_DEFINITION: struct mutex definition without comment
#535: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:78:
+	struct mutex key_lock;

-:645: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#645: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:188:
+		dp_hdcp_write_key(hdcp, DP_HDCP_KEY_LSB(i),
+				 hdcp->key.keys[i].words[0]);

-:647: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#647: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:190:
+		dp_hdcp_write_key(hdcp, DP_HDCP_KEY_MSB(i),
+				 hdcp->key.keys[i].words[1]);

-:653: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#653: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:196:
+	dp_hdcp_write_link(hdcp, DP_HDCP_ENTROPY_CTRL0,
+			      FIELD_GET(GENMASK(31,0), an_seed));

-:653: ERROR:SPACING: space required after that ',' (ctx:VxV)
#653: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:196:
+			      FIELD_GET(GENMASK(31,0), an_seed));
 			                          ^

-:655: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#655: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:198:
+	dp_hdcp_write_link(hdcp, DP_HDCP_ENTROPY_CTRL1,
+			      FIELD_GET(GENMASK_ULL(63,32), an_seed));

-:655: ERROR:SPACING: space required after that ',' (ctx:VxV)
#655: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:198:
+			      FIELD_GET(GENMASK_ULL(63,32), an_seed));
 			                              ^

-:693: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#693: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.c:236:
+	ret = read_poll_timeout(dp_hdcp_read_ahb, val,
+		(val & DP_HDCP_AN_READY_MASK) == DP_HDCP_AN_READY_MASK,

-:926: WARNING:SPDX_LICENSE_TAG: Improper SPDX comment style for 'drivers/gpu/drm/msm/dp/dp_hdcp.h', please use '/*' instead
#926: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.h:1:
+// SPDX-License-Identifier: MIT

-:926: WARNING:SPDX_LICENSE_TAG: Missing or malformed SPDX-License-Identifier tag in line 1
#926: FILE: drivers/gpu/drm/msm/dp/dp_hdcp.h:1:
+// SPDX-License-Identifier: MIT

-:986: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#986: FILE: drivers/gpu/drm/msm/dp/dp_parser.c:102:
+				DRM_ERROR("unable to remap hdcp_tz region: %pe\n",
+					dss->hdcp_tz.base);

total: 3 errors, 6 warnings, 10 checks, 997 lines checked

More information about the Intel-gfx mailing list