[Intel-gfx] [PATCH] drm/i915/guc/slpc: Check GuC status before freq boost

Dixit, Ashutosh ashutosh.dixit at intel.com
Fri Nov 12 16:05:35 UTC 2021


On Thu, 11 Nov 2021 23:10:16 -0800, Vinay Belgaumkar wrote:
>
> diff --git a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> index 4e1d3cd29164..22c1c12369f2 100644
> --- a/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> +++ b/drivers/gpu/drm/i915/gt/uc/intel_guc_slpc.c
> @@ -183,11 +183,15 @@ static int slpc_unset_param(struct intel_guc_slpc *slpc,
>  static int slpc_force_min_freq(struct intel_guc_slpc *slpc, u32 freq)
>  {
>	struct drm_i915_private *i915 = slpc_to_i915(slpc);
> +	struct intel_guc *guc = slpc_to_guc(slpc);
>	intel_wakeref_t wakeref;
>	int ret = 0;
>
>	lockdep_assert_held(&slpc->lock);
>
> +	if (!intel_guc_is_ready(guc))
> +		return -ENODEV;
> +

Reviewed-by: Ashutosh Dixit <ashutosh.dixit at intel.com>

The test wedges/resets the GPU after a request is queued but before it is
retired.



More information about the Intel-gfx mailing list