[Intel-gfx] [PATCH 9/9] drm/i915: Clean up FPGA_DBG/CLAIM_ER bits
Rodrigo Vivi
rodrigo.vivi at intel.com
Mon Nov 15 19:05:19 UTC 2021
On Fri, Nov 12, 2021 at 09:38:13PM +0200, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Use REG_BIT() & co. for FPGA_DBG/CLAIM_ER bits.
>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
> ---
> drivers/gpu/drm/i915/i915_reg.h | 8 ++++----
> 1 file changed, 4 insertions(+), 4 deletions(-)
>
> diff --git a/drivers/gpu/drm/i915/i915_reg.h b/drivers/gpu/drm/i915/i915_reg.h
> index 0ceb88828d93..a4d6bd380012 100644
> --- a/drivers/gpu/drm/i915/i915_reg.h
> +++ b/drivers/gpu/drm/i915/i915_reg.h
> @@ -2821,12 +2821,12 @@ static inline bool i915_mmio_reg_valid(i915_reg_t reg)
> #define GEN12_AUX_ERR_DBG _MMIO(0x43f4)
>
> #define FPGA_DBG _MMIO(0x42300)
> -#define FPGA_DBG_RM_NOCLAIM (1 << 31)
> +#define FPGA_DBG_RM_NOCLAIM REG_BIT(31)
>
> #define CLAIM_ER _MMIO(VLV_DISPLAY_BASE + 0x2028)
> -#define CLAIM_ER_CLR (1 << 31)
> -#define CLAIM_ER_OVERFLOW (1 << 16)
> -#define CLAIM_ER_CTR_MASK 0xffff
> +#define CLAIM_ER_CLR REG_BIT(31)
> +#define CLAIM_ER_OVERFLOW REG_BIT(16)
> +#define CLAIM_ER_CTR_MASK REG_GENMASK(15, 0)
>
> #define DERRMR _MMIO(0x44050)
> /* Note that HBLANK events are reserved on bdw+ */
> --
> 2.32.0
>
More information about the Intel-gfx
mailing list