[Intel-gfx] [RFC 2/7] drm/i915/guc: Update GuC ADS size for error capture lists

[Jani Nikula]

On Tue, 23 Nov 2021, Michal Wajdeczko <michal.wajdeczko at intel.com> wrote:
> Hi,
>
> just few random nits below
>
> -Michal
>
>
> On 23.11.2021 00:03, Alan Previn wrote:
>> +/* Define all device tables of GuC error capture register lists */
>> +
>> +/********************************* Gen12 LP  *********************************/
>
> didn't we move away from "GEN" naming ?

Yes.

>
>> +/************** GLOBAL *************/
>
> do we really need all these decorations ?

No, please remove them.

>
>> +struct __guc_mmio_reg_descr gen12lp_global_regs[] = {
>> +	{SWF_ILK(0),               0,      0, "SWF_ILK0"},
>> +	/* Add additional register list */
>
> do we need this reminder ?

No, please remove them.

Also, all of these need to be static.


BR,
Jani.


-- 
Jani Nikula, Intel Open Source Graphics Center