[Intel-gfx] [PATCH 00/20] drm/i915/fbc: More FBC refactoring

[Jani Nikula]

On Wed, 24 Nov 2021, Ville Syrjala <ville.syrjala at linux.intel.com> wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Continue refactoring the FBC code towards multiple FBC
> instances and more flexible plane<->FBC assignment.

There's a lot to like here. I haven't done detailed review, but apart
from the comment on the debugfs split, the series is

Acked-by: Jani Nikula <jani.nikula at intel.com>

>
> Ville Syrjälä (20):
>   drm/i915/fbc: Eliminate racy intel_fbc_is_active() usage
>   drm/i915/fbc: Pass whole plane state to intel_fbc_min_limit()
>   drm/i915/fbc: Nuke lots of crap from intel_fbc_state_cache
>   drm/i915/fbc: Relocate intel_fbc_override_cfb_stride()
>   drm/i915/fbc: Nuke more FBC state
>   drm/i915/fbc: Reuse the same struct for the cache and params
>   drm/i915/fbc: Pass around FBC instance instead of crtc
>   drm/i915/fbc: Track FBC usage per-plane
>   drm/i915/fbc: Flatten __intel_fbc_pre_update()
>   drm/i915/fbc: Pass i915 instead of FBC instance to FBC underrun stuff
>   drm/i915/fbc: Move FBC debugfs stuff into intel_fbc.c
>   drm/i915/fbc: Introduce intel_fbc_add_plane()
>   drm/i915/fbc: Allocate intel_fbc dynamically
>   drm/i915/fbc: Move stuff from intel_fbc_can_enable() into
>     intel_fbc_check_plane()
>   drm/i915/fbc: Disable FBC fully on FIFO underrun
>   drm/i915/fbc: Nuke state_cache
>   drm/i915/fbc: Move plane pointer into intel_fbc_state
>   drm/i915/fbc: s/parms/fbc_state/
>   drm/i915/fbc: No FBC+double wide pipe
>   drm/i915/fbc: Pimp the FBC debugfs output
>
>  drivers/gpu/drm/i915/display/i9xx_plane.c     |   15 +-
>  drivers/gpu/drm/i915/display/intel_display.c  |    5 +-
>  .../drm/i915/display/intel_display_debugfs.c  |   54 +-
>  .../drm/i915/display/intel_display_types.h    |    4 +-
>  drivers/gpu/drm/i915/display/intel_fbc.c      | 1231 +++++++++--------
>  drivers/gpu/drm/i915/display/intel_fbc.h      |   13 +-
>  .../drm/i915/display/intel_fifo_underrun.c    |    2 +-
>  .../drm/i915/display/skl_universal_plane.c    |   15 +-
>  drivers/gpu/drm/i915/i915_drv.h               |  101 +-
>  drivers/gpu/drm/i915/i915_trace.h             |   18 +-
>  drivers/gpu/drm/i915/intel_pm.c               |    9 +-
>  11 files changed, 690 insertions(+), 777 deletions(-)

-- 
Jani Nikula, Intel Open Source Graphics Center