[Intel-gfx] [PATCH 3/4] drm/i915: Remove the drm_dbg() from the vblank evade critical section

Li, Juston juston.li at intel.com
Thu Oct 7 05:54:47 UTC 2021


On Thu, 2021-10-07 at 02:57 +0300, Ville Syrjala wrote:
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> 
> We are inside the vblank evade critical section here, racing
> against the raster beam. There is no time to print debug
> messages.
> 
> Cc: Anshuman Gupta <anshuman.gupta at intel.com>
> Cc: Daniele Ceraolo Spurio <daniele.ceraolospurio at intel.com>
> Cc: Juston Li <juston.li at intel.com>
> Cc: Rodrigo Vivi <rodrigo.vivi at intel.com>
> Cc: Uma Shankar <uma.shankar at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

Reviewed-by: Juston Li <juston.li at intel.com>

> ---
>  drivers/gpu/drm/i915/display/skl_universal_plane.c | 2 --
>  1 file changed, 2 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> index 55dae8c8fcad..1e85ea98231f 100644
> --- a/drivers/gpu/drm/i915/display/skl_universal_plane.c
> +++ b/drivers/gpu/drm/i915/display/skl_universal_plane.c
> @@ -1018,8 +1018,6 @@ static void intel_load_plane_csc_black(struct
> intel_plane *intel_plane)
>         enum plane_id plane = intel_plane->id;
>         u16 postoff = 0;
>  
> -       drm_dbg_kms(&dev_priv->drm, "plane color CTM to black 
> %s:%d\n",
> -                   intel_plane->base.name, plane);
>         intel_de_write_fw(dev_priv, PLANE_CSC_COEFF(pipe, plane, 0),
> 0);
>         intel_de_write_fw(dev_priv, PLANE_CSC_COEFF(pipe, plane, 1),
> 0);
>  



More information about the Intel-gfx mailing list