[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915/dg2: update link training for 128b/132b (rev2)

[Patchwork]

== Series Details ==

Series: drm/i915/dg2: update link training for 128b/132b (rev2)
URL   : https://patchwork.freedesktop.org/series/95317/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
eda15c6a42a6 drm/i915/dg2: update link training for 128b/132b
-:47: WARNING:UNNECESSARY_ELSE: else is not generally useful after a break or return
#47: FILE: drivers/gpu/drm/i915/display/intel_ddi.c:1349:
+		return train_set & DP_TX_FFE_PRESET_VALUE_MASK;
+	} else {

-:79: CHECK:LINE_SPACING: Please don't use multiple blank lines
#79: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:307:
 
+

-:134: ERROR:COMPLEX_MACRO: Macros with complex values should be enclosed in parentheses
#134: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:503:
+#define TRAIN_SET_TX_FFE_ARGS(train_set) \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[0]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[1]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[2]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[3])

-:134: CHECK:MACRO_ARG_REUSE: Macro argument reuse 'train_set' - possible side-effects?
#134: FILE: drivers/gpu/drm/i915/display/intel_dp_link_training.c:503:
+#define TRAIN_SET_TX_FFE_ARGS(train_set) \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[0]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[1]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[2]), \
+	_TRAIN_SET_TX_FFE_ARGS((train_set)[3])

total: 1 errors, 1 warnings, 2 checks, 204 lines checked