[Intel-gfx] [RFC PATCH 0/8] drm/i915/display: refactor plane config + pin out

Dave Airlie airlied at gmail.com
Tue Oct 12 04:18:05 UTC 2021


On Thu, 7 Oct 2021 at 21:09, Ville Syrjälä
<ville.syrjala at linux.intel.com> wrote:
>
> On Thu, Oct 07, 2021 at 01:52:42PM +0300, Jani Nikula wrote:
> > On Thu, 07 Oct 2021, Dave Airlie <airlied at gmail.com> wrote:
> > > This is another series in the refactor intel_display.c into more manageable
> > > places.
> > >
> > > This moves the initial plane config and all the fb pin/unpin code out.
> > >
> > > It also refactors both a little to make the interfaces cleaner.
> >
> > I had a few nitpicks I commented on. Overall this looks good to me, but
> > I'd like Ville's input on the code movement at the high level, are the
> > split and files sane etc. I can do the detailed review after that.
>
> Some of it feels a bit ad-hoc, but I don't really have a better
> idea for splitting some of these right now. So might as well go
> with this I guess. cscope will find the stuff for me in the end,
> at least after I remember to have it reindex.

My main goal was separation of things that interface with gem into
separate files for now.

I'd like to formalise that interface a bit more if we can, it might
not bear fruit but I think it would be independently useful cleanup
anyways.

Dave.


More information about the Intel-gfx mailing list