[Intel-gfx] [PATCH 4/5] drm/i915/gt: Random clean up of comments around display version.
Rodrigo Vivi
rodrigo.vivi at intel.com
Thu Oct 14 17:12:56 UTC 2021
Although gen12 is a valid thing for the gt side on TGL,
we should prefer graphics version over the old global "gen" thing.
Of course we are not changing functions and variables and the legacy
there, but at least let's start to document things properly and
set some good examples.
Cc: Joonas Lahtinen <joonas.lahtinen at linux.intel.com>
Signed-off-by: Rodrigo Vivi <rodrigo.vivi at intel.com>
---
drivers/gpu/drm/i915/gt/intel_execlists_submission.c | 2 +-
drivers/gpu/drm/i915/gt/intel_lrc.c | 8 ++++----
2 files changed, 5 insertions(+), 5 deletions(-)
diff --git a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
index 73a79c2acd3a..b6b9d324f519 100644
--- a/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
+++ b/drivers/gpu/drm/i915/gt/intel_execlists_submission.c
@@ -1650,7 +1650,7 @@ static void invalidate_csb_entries(const u64 *first, const u64 *last)
}
/*
- * Starting with Gen12, the status has a new format:
+ * Starting with Graphics version 12, the status has a new format:
*
* bit 0: switched to new queue
* bit 1: reserved
diff --git a/drivers/gpu/drm/i915/gt/intel_lrc.c b/drivers/gpu/drm/i915/gt/intel_lrc.c
index 3ef9eaf8c50e..ed0f0e81bb56 100644
--- a/drivers/gpu/drm/i915/gt/intel_lrc.c
+++ b/drivers/gpu/drm/i915/gt/intel_lrc.c
@@ -611,10 +611,10 @@ static const u8 dg2_rcs_offsets[] = {
static const u8 *reg_offsets(const struct intel_engine_cs *engine)
{
/*
- * The gen12+ lists only have the registers we program in the basic
- * default state. We rely on the context image using relative
- * addressing to automatic fixup the register state between the
- * physical engines for virtual engine.
+ * The graphics 12 and newer platforms, lists only have the registers we
+ * program in the basic default state. We rely on the context image
+ * using relative addressing to automatic fixup the register state
+ * between the physical engines for virtual engine.
*/
GEM_BUG_ON(GRAPHICS_VER(engine->i915) >= 12 &&
!intel_engine_has_relative_mmio(engine));
--
2.31.1
More information about the Intel-gfx
mailing list