[Intel-gfx] [PATCH 9/9] drm/i915: Introduce lpt_pch_disable()

David Airlie airlied at redhat.com
Mon Oct 18 00:44:25 UTC 2021


On Fri, Oct 15, 2021 at 5:17 PM Ville Syrjala
<ville.syrjala at linux.intel.com> wrote:
>
> From: Ville Syrjälä <ville.syrjala at linux.intel.com>
>
> Let's add lpt_pch_disable() as the counterpart to
> lpt_pch_enable().
>
> Note that unlike the ilk+ code the fdi_link_train()
> and fdi_disable() calls are still left directly in
> intel_crt.c. If we wanted to move those we'd need to
> add lpt_pch_pre_enable(). But the two fdi direct fdi
> calls are pretry symmetric so it doesn't seem too bad
> to just keep them as is.
>
> Cc: Dave Airlie <airlied at redhat.com>
> Cc: Jani Nikula <jani.nikula at intel.com>
> Signed-off-by: Ville Syrjälä <ville.syrjala at linux.intel.com>

apart from krobot suggestions.


Reviewed-by: Dave Airlie <airlied at redhat.com>



More information about the Intel-gfx mailing list