[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: split out audio private from dev_priv

Patchwork patchwork at emeril.freedesktop.org
Fri Oct 22 20:39:29 UTC 2021


== Series Details ==

Series: drm/i915: split out audio private from dev_priv
URL   : https://patchwork.freedesktop.org/series/96195/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
4d684e513941 drm/i915/audio: group audio under anonymous struct in drm_i915_private
7dde34aa454e drm/i915/audio: name the audio sub-struct in drm_i915_private
-:315: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#315: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1371:
+	if ((dev_priv)->audio.lpe.platdev != NULL)

-:328: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#328: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:77:
+#define HAS_LPE_AUDIO(dev_priv) ((dev_priv)->audio.lpe.platdev != NULL)

-:337: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#337: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:99:
+	rsc[0].start    = rsc[0].end = dev_priv->audio.lpe.irq;

total: 0 errors, 0 warnings, 3 checks, 438 lines checked
f6bfd155afcd drm/i915/audio: define the audio struct separately from drm_i915_private
4ba26336de5d drm/i915/audio: move intel_audio_funcs internal to intel_audio.c




More information about the Intel-gfx mailing list