[Intel-gfx] [PATCH v2 2/9] Revert "drm/i915/display: Disable audio, DRRS and PSR before planes"

[Ville Syrjälä]

On Tue, Oct 26, 2021 at 07:39:27PM +0000, Souza, Jose wrote:
> On Fri, 2021-10-22 at 13:32 +0300, Ville Syrjala wrote:
> > From: Ville Syrjälä <ville.syrjala at linux.intel.com>
> > 
> > Disabling planes in the middle of the modeset seuqnece does not make
> > sense since userspace can anyway disable planes before the modeset
> > even starts. So when the modeset seuqence starts the set of enabled
> > planes is entirely arbitrary. Trying to sprinkle the plane disabling
> > into the modeset sequence just means more randomness and potential
> > for hard to reproduce bugs.
> > 
> > So it makes most sense to just disable all planes first so that the
> > rest of the modeset sequence remains identical regardless of which
> > planes happen to be enabled by userspace at the time.
> > 
> > This reverts commit 84030adb9e27d202a66022488bf0349a8bd45213.
> 
> With the 'drm/i915/psr: Disable PSR before modesets turn off all planes' it is now okay to revert this.
> 
> Reviewed-by: José Roberto de Souza <jose.souza at intel.com>

Thanks for the reviews everyone. Series pushed to drm-intel-next.

-- 
Ville Syrjälä
Intel