[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for series starting with [v2,1/6] drm/i915/audio: group audio under anonymous struct in drm_i915_private

Patchwork patchwork at emeril.freedesktop.org
Thu Oct 28 21:13:05 UTC 2021


== Series Details ==

Series: series starting with [v2,1/6] drm/i915/audio: group audio under anonymous struct in drm_i915_private
URL   : https://patchwork.freedesktop.org/series/96399/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
99ae5429914a drm/i915/audio: group audio under anonymous struct in drm_i915_private
a782cd9b4623 drm/i915/audio: name the audio sub-struct in drm_i915_private
-:322: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#322: FILE: drivers/gpu/drm/i915/display/intel_audio.c:1371:
+	if ((dev_priv)->audio.lpe.platdev != NULL)

-:335: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "audio.lpe.platdev"
#335: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:77:
+#define HAS_LPE_AUDIO(dev_priv) ((dev_priv)->audio.lpe.platdev != NULL)

-:344: CHECK:MULTIPLE_ASSIGNMENTS: multiple assignments should be avoided
#344: FILE: drivers/gpu/drm/i915/display/intel_lpe_audio.c:99:
+	rsc[0].start    = rsc[0].end = dev_priv->audio.lpe.irq;

total: 0 errors, 0 warnings, 3 checks, 438 lines checked
54360d96b9b3 drm/i915/audio: define the audio struct separately from drm_i915_private
b8d059680c73 drm/i915/audio: move intel_audio_funcs internal to intel_audio.c
cb77ff6f4e63 drm/i915/audio: clean up LPE audio init/cleanup calls
d4f0b49238d0 drm/i915/audio: rename intel_init_audio_hooks to intel_audio_hooks_init




More information about the Intel-gfx mailing list