[Intel-gfx] [PATCH 3/5] drm/i915/debugfs: register LPSP capability on all platforms

Rodrigo Vivi rodrigo.vivi at intel.com
Wed Sep 1 16:19:05 UTC 2021


On Mon, Aug 30, 2021 at 03:53:42PM +0300, Jani Nikula wrote:
> The debugfs file shows it's not capable, don't duplicate the info.

okay, but the file is useless if not supported right?!
I believe the goal here was even avoid the file creation...

But either way:
If this is not breaking IGT:
Reviewed-by: Rodrigo Vivi <rodrigo.vivi at intel.com>


> 
> Signed-off-by: Jani Nikula <jani.nikula at intel.com>
> ---
>  .../gpu/drm/i915/display/intel_display_debugfs.c    | 13 +++++--------
>  1 file changed, 5 insertions(+), 8 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_display_debugfs.c b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> index a6dcb95cfc1f..c1cd5d005e08 100644
> --- a/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> +++ b/drivers/gpu/drm/i915/display/intel_display_debugfs.c
> @@ -2486,14 +2486,11 @@ int intel_connector_debugfs_add(struct drm_connector *connector)
>  				    connector, &i915_dsc_bpp_fops);
>  	}
>  
> -	/* Legacy panels doesn't lpsp on any platform */
> -	if ((DISPLAY_VER(dev_priv) >= 9 || IS_HASWELL(dev_priv) ||
> -	     IS_BROADWELL(dev_priv)) &&
> -	     (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> -	     connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> -	     connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> -	     connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> -	     connector->connector_type == DRM_MODE_CONNECTOR_HDMIB))
> +	if (connector->connector_type == DRM_MODE_CONNECTOR_DSI ||
> +	    connector->connector_type == DRM_MODE_CONNECTOR_eDP ||
> +	    connector->connector_type == DRM_MODE_CONNECTOR_DisplayPort ||
> +	    connector->connector_type == DRM_MODE_CONNECTOR_HDMIA ||
> +	    connector->connector_type == DRM_MODE_CONNECTOR_HDMIB)
>  		debugfs_create_file("i915_lpsp_capability", 0444, root,
>  				    connector, &i915_lpsp_capability_fops);
>  
> -- 
> 2.20.1
> 


More information about the Intel-gfx mailing list