[Intel-gfx] [PATCH 1/4] drm/i915: rename debugfs_gt files

Lucas De Marchi lucas.demarchi at intel.com
Tue Sep 14 14:46:01 UTC 2021


On Tue, Sep 14, 2021 at 12:16:13PM +0300, Jani Nikula wrote:
>On Wed, 08 Sep 2021, Lucas De Marchi <lucas.demarchi at intel.com> wrote:
>> We shouldn't be using debugfs_ namespace for this functionality. Rename
>> debugfs_gt.[ch] to intel_gt_debugfs.[ch] and then make functions,
>> defines and structs follow suit.
>>
>> While at it and since we are renaming the header, sort the includes
>> alphabetically.
>
>I didn't do a detailed review, maybe someone should, but superficially
>seems good. On the series,
>
>Acked-by: Jani Nikula <jani.nikula at intel.com>

thanks. What about the question I raised on

intel_gt_register_debugfs() vs
intel_gt_debugfs_register()?

and

intel_gt_pm_register_debugfs() vs
intel_gt_pm_debugfs_register()?

what would be prefered here?

thanks
Lucas De Marchi


More information about the Intel-gfx mailing list