[Intel-gfx] [PATCH 6/7] drm/i915/display/adlp: Allow PSR2 to be enabled

Gwan-gyeong Mun gwan-gyeong.mun at intel.com
Wed Sep 29 13:29:18 UTC 2021


Reviewed-by: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>

On 9/23/21 10:46 PM, José Roberto de Souza wrote:
> With all the recent fixes PSR2 is properly working in Alderlake-P but
> due to some issues that don't have software workarounds it will not be
> supported in display steppings older than B0.
> 
> Even with this patch PSR2 will no be enabled by default in ADL-P, it
> still requires enable_psr2_sel_fetch to be set to true, what some
> of our tests does.
> 
> Cc: Gwan-gyeong Mun <gwan-gyeong.mun at intel.com>
> Signed-off-by: José Roberto de Souza <jose.souza at intel.com>
> ---
>   drivers/gpu/drm/i915/display/intel_psr.c | 8 ++------
>   1 file changed, 2 insertions(+), 6 deletions(-)
> 
> diff --git a/drivers/gpu/drm/i915/display/intel_psr.c b/drivers/gpu/drm/i915/display/intel_psr.c
> index 001d81f128989..37727ff2b2ec9 100644
> --- a/drivers/gpu/drm/i915/display/intel_psr.c
> +++ b/drivers/gpu/drm/i915/display/intel_psr.c
> @@ -830,12 +830,8 @@ static bool intel_psr2_config_valid(struct intel_dp *intel_dp,
>   		return false;
>   	}
>   
> -	/*
> -	 * We are missing the implementation of some workarounds to enabled PSR2
> -	 * in Alderlake_P, until ready PSR2 should be kept disabled.
> -	 */
> -	if (IS_ALDERLAKE_P(dev_priv)) {
> -		drm_dbg_kms(&dev_priv->drm, "PSR2 is missing the implementation of workarounds\n");
> +	if (IS_ADLP_DISPLAY_STEP(dev_priv, STEP_A0, STEP_B0)) {
> +		drm_dbg_kms(&dev_priv->drm, "PSR2 not completely functional in this stepping\n");
>   		return false;
>   	}
>   
> 


More information about the Intel-gfx mailing list