[Intel-gfx] [PATCH 3/4] drm/fourcc: Introduce format modifier for DG2 clear color

Juha-Pekka Heikkila juhapekka.heikkila at gmail.com
Thu Apr 7 13:37:48 UTC 2022


Reviewed-by: Juha-Pekka Heikkila <juhapekka.heikkila at gmail.com>

On 4.4.2022 16.38, Imre Deak wrote:
> From: Mika Kahola <mika.kahola at intel.com>
> 
> DG2 clear color render compression uses Tile4 layout. Therefore, we need
> to define a new format modifier for uAPI to support clear color rendering.
> 
> v2:
>    Display version is fixed. [Imre]
>    KDoc is enhanced for cc modifier. [Nanley & Lionel]
> v3:
>    Split out the modifier addition to a separate patch.
>    Clarify the modifier layout description.
> 
> Cc: dri-devel at lists.freedesktop.org
> Signed-off-by: Mika Kahola <mika.kahola at intel.com>
> cc: Anshuman Gupta <anshuman.gupta at intel.com>
> Signed-off-by: Juha-Pekka Heikkilä <juha-pekka.heikkila at intel.com>
> Signed-off-by: Ramalingam C <ramalingam.c at intel.com>
> Signed-off-by: Imre Deak <imre.deak at intel.com>
> Acked-by: Nanley Chery <nanley.g.chery at intel.com>
> ---
>   include/uapi/drm/drm_fourcc.h | 14 ++++++++++++++
>   1 file changed, 14 insertions(+)
> 
> diff --git a/include/uapi/drm/drm_fourcc.h b/include/uapi/drm/drm_fourcc.h
> index 4a5117715db3c..e5074162bcdd4 100644
> --- a/include/uapi/drm/drm_fourcc.h
> +++ b/include/uapi/drm/drm_fourcc.h
> @@ -605,6 +605,20 @@ extern "C" {
>    */
>   #define I915_FORMAT_MOD_4_TILED_DG2_MC_CCS fourcc_mod_code(INTEL, 11)
>   
> +/*
> + * Intel Color Control Surface with Clear Color (CCS) for DG2 render compression.
> + *
> + * The main surface is Tile 4 and at plane index 0. The CCS data is stored
> + * outside of the GEM object in a reserved memory area dedicated for the
> + * storage of the CCS data for all RC/RC_CC/MC compressible GEM objects. The
> + * main surface pitch is required to be a multiple of four Tile 4 widths. The
> + * clear color is stored at plane index 1 and the pitch should be ignored. The
> + * format of the 256 bits of clear color data matches the one used for the
> + * I915_FORMAT_MOD_Y_TILED_GEN12_RC_CCS_CC modifier, see its description
> + * for details.
> + */
> +#define I915_FORMAT_MOD_4_TILED_DG2_RC_CCS_CC fourcc_mod_code(INTEL, 12)
> +
>   /*
>    * Tiled, NV12MT, grouped in 64 (pixels) x 32 (lines) -sized macroblocks
>    *



More information about the Intel-gfx mailing list