[Intel-gfx] [PATCH v3] drm: add a check to verify the size alignment

[Christian König]

Am 11.04.22 um 15:49 schrieb Arunpravin Paneer Selvam:
>
> On 11/04/22 7:02 pm, Matthew Auld wrote:
>> On 11/04/2022 13:42, Christian König wrote:
>>> Am 11.04.22 um 11:47 schrieb Matthew Auld:
>>>> On 11/04/2022 08:38, Arunpravin Paneer Selvam wrote:
>>>>> Add a simple check to reject any size not aligned to the
>>>>> min_page_size.
>>>>>
>>>>> when size is not aligned to min_page_size, driver module
>>>>> should handle in their own way either to round_up() the
>>>>> size value to min_page_size or just to enable WARN_ON().
>>>>>
>>>>> If we dont handle the alignment properly, we may hit the
>>>>> following bug, Unigine Heaven has allocation requests for
>>>>> example required pages are 257 and alignment request is 256.
>>>>> To allocate the left over 1 page, continues the iteration to
>>>>> find the order value which is 0 and when it compares with
>>>>> min_order = 8, triggers the BUG_ON(order < min_order).
>>>>>
>>>>> v2: add more commit description
>>>>> v3: remove WARN_ON()
>>>>>
>>>>> Signed-off-by: Arunpravin Paneer Selvam
>>>>> <Arunpravin.PaneerSelvam at amd.com>
>>>>> Suggested-by: Matthew Auld <matthew.auld at intel.com>
>>>> Reviewed-by: Matthew Auld <matthew.auld at intel.com>
>>>>
>>> Question here is who will be pushing that to drm-misc-next? Should I
>>> take care of that?
>> Yes, please do.
>>
>>> I think it's time that Arun should request push permission for
>>> drm-misc-next.
> How to get push permission for drm-misc-next, should I send request mail
> to maintainers, may be next time I will push myself.

See here 
https://drm.pages.freedesktop.org/maintainer-tools/commit-access.html

Regards,
Christian.

>
> Thanks,
> Arun
>>> Thanks,
>>> Christian.