[Intel-gfx] [PATCH 3/9] vfio/mdev: Pass in a struct vfio_device * to vfio_pin/unpin_pages()

Jason Gunthorpe jgg at nvidia.com
Wed Apr 13 11:40:59 UTC 2022


On Wed, Apr 13, 2022 at 07:57:17AM +0200, Christoph Hellwig wrote:
> > -	extern int vfio_pin_pages(struct device *dev, unsigned long *user_pfn,
> > +	extern int vfio_pin_pages(struct vfio_device *vdev, unsigned long *user_pfn,
> >  				  int npage, int prot, unsigned long *phys_pfn);
> >  
> > -	extern int vfio_unpin_pages(struct device *dev, unsigned long *user_pfn,
> > +	extern int vfio_unpin_pages(struct vfio_device *vdev, unsigned long *user_pfn,
> 
> Please drop the externs when you touch this (also for the actual
> header).

Alex has been asking to keep them in the H files for consistency

Removing from the docs should be fine though

Thanks,
Jason


More information about the Intel-gfx mailing list