[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Replace shmem memory region and object backend with TTM

Patchwork patchwork at emeril.freedesktop.org
Thu Apr 28 08:54:41 UTC 2022


== Series Details ==

Series: Replace shmem memory region and object backend with TTM
URL   : https://patchwork.freedesktop.org/series/103259/
State : warning

== Summary ==

Error: dim checkpatch failed
d619a74d74ea drm/i915: Replace shmem memory region and object backend with TTM
-:37: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#37: FILE: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:101:
+	GEM_BUG_ON(obj->base.import_attach != NULL);

-:63: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#63: FILE: drivers/gpu/drm/i915/gem/i915_gem_dmabuf.c:231:
+	GEM_BUG_ON(obj->base.import_attach != NULL);

-:94: CHECK:BRACES: Unbalanced braces around else statement
#94: FILE: drivers/gpu/drm/i915/gem/i915_gem_mman.c:90:
+	else {

-:184: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "obj->base.import_attach"
#184: FILE: drivers/gpu/drm/i915/gem/i915_gem_phys.c:32:
+	GEM_BUG_ON(obj->base.import_attach != NULL);

-:579: CHECK:COMPARISON_TO_NULL: Comparison to NULL could be written "!file"
#579: FILE: drivers/gpu/drm/i915/gem/i915_gem_shmem.c:316:
+	GEM_WARN_ON(file == NULL);

-:704: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'caching != ttm_write_combined'
#704: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm.c:326:
+	if (i915_gem_object_is_shrinkable(obj) && (caching != ttm_write_combined)) {

-:989: CHECK:BRACES: Blank lines aren't necessary after an open brace '{'
#989: FILE: drivers/gpu/drm/i915/gem/i915_gem_ttm_move.c:49:
 {
+

total: 0 errors, 0 warnings, 7 checks, 979 lines checked




More information about the Intel-gfx mailing list