[Intel-gfx] [PATCH v6 0/4] drm/i915/display: stop HPD workers before display driver unregister

Gwan-gyeong Mun gwan-gyeong.mun at intel.com
Tue Aug 2 12:24:11 UTC 2022


Hi Jani, Ville and Imre,

If there are no problems after reviewing this patch series, could you 
please merge it?

Many thanks,
G.G.

On 7/22/22 3:51 PM, Andrzej Hajda wrote:
> Hi Jani, Ville, Arun,
> 
> This patchset is replacement of patch
> "drm/i915/display: disable HPD workers before display driver unregister" [1].
> Ive decided to split patch into two parts - fbdev and MST, there are different
> issues.
> Ive also dropped shutdown path, as it has slightly different requirements,
> and more importantly I am not able to test properly.
> 
> v2 (thx Arun for review):
>    - reword of commit message (Arun)
>    - intel_fbdev_hpd_set_suspend replaced with intel_fbdev_set_suspend (Arun)
> v3:
>    - new patch adding suspended flag, to handle
>      https://gitlab.freedesktop.org/drm/intel/-/issues/5950
> v4:
>    - check suspend flag also in i915_digport_work_func
> v5:
>    - added patch blocking FB creation in case HPD is supended,
>    - added R-B from Arun to patch 3, thx
> v6:
>    - finally, after getting direct access to bat-rpls-2, I have found the source of last WARN,
>      intel_fbdev_hpd_set_suspend was not called in case of deferred setup, fixed in patch 2.
> 
> [1]: https://patchwork.freedesktop.org/series/103811/
> 
> Regards
> Andrzej
> 
> 
> Andrzej Hajda (4):
>    drm/i915/hpd: postpone HPD cancel work after last user suspension
>    drm/i915/fbdev: suspend HPD before fbdev unregistration
>    drm/i915/display: add hotplug.suspended flag
>    drm/i915/fbdev: do not create fbdev if HPD is suspended
> 
>   drivers/gpu/drm/i915/display/intel_display.c |  3 +++
>   drivers/gpu/drm/i915/display/intel_fbdev.c   | 12 ++++++++++--
>   drivers/gpu/drm/i915/display/intel_hotplug.c | 11 ++++++++++-
>   drivers/gpu/drm/i915/display/intel_hotplug.h |  2 +-
>   drivers/gpu/drm/i915/i915_driver.c           |  4 ++--
>   drivers/gpu/drm/i915/i915_drv.h              |  2 ++
>   drivers/gpu/drm/i915/i915_irq.c              |  1 -
>   7 files changed, 28 insertions(+), 7 deletions(-)
> 


More information about the Intel-gfx mailing list