[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for Add KUnit support for i915 mock selftests

Patchwork patchwork at emeril.freedesktop.org
Thu Dec 1 12:47:14 UTC 2022


== Series Details ==

Series: Add KUnit support for i915 mock selftests
URL   : https://patchwork.freedesktop.org/series/111530/
State : warning

== Summary ==

Error: dim checkpatch failed
729ffb89e113 drm/i915: place selftest preparation on a separate function
b4a91d0d11ad drm/i915: export all mock selftest functions
21f5325a221b drm/i915: allow running mock selftests via Kunit
Traceback (most recent call last):
  File "scripts/spdxcheck.py", line 11, in <module>
    import git
ModuleNotFoundError: No module named 'git'
-:24: WARNING:COMMIT_LOG_LONG_LINE: Possible unwrapped commit description (prefer a maximum 75 chars per line)
#24: 
	$ qemu-system-x86_64 -nodefaults -m 1024 -kernel .kunit/arch/x86/boot/bzImage -append 'kunit.enable=1 console=ttyS0 kunit_shutdown=reboot' -no-reboot -nographic -serial stdio

-:269: WARNING:FILE_PATH_CHANGES: added, moved or deleted file(s), does MAINTAINERS need updating?
#269: 
new file mode 100644

-:340: CHECK:PARENTHESIS_ALIGNMENT: Alignment should match open parenthesis
#340: FILE: drivers/gpu/drm/i915/selftests/i915_kunit.c:49:
+	pr_notice("Setting dangerous option KUnit %s - tainting kernel\n",
+			  test->name);

-:351: WARNING:TRAILING_SEMICOLON: macros should not use a trailing semicolon
#351: FILE: drivers/gpu/drm/i915/selftests/i915_kunit.c:60:
+#define selftest(x, __y) int __y(void);

-:357: ERROR:OPEN_BRACE: open brace '{' following function definitions go on the next line
#357: FILE: drivers/gpu/drm/i915/selftests/i915_kunit.c:66:
+	static void mock_##__x(struct kunit *test) {	\

-:369: CHECK:LINE_SPACING: Please use a blank line after function/struct/union/enum declarations
#369: FILE: drivers/gpu/drm/i915/selftests/i915_kunit.c:78:
+};
+#undef selftest

-:385: WARNING:MODULE_LICENSE: Prefer "GPL" over "GPL v2" - see commit bf7fbeeae6db ("module: Cure the MODULE_LICENSE "GPL" vs. "GPL v2" bogosity")
#385: FILE: drivers/gpu/drm/i915/selftests/i915_kunit.c:94:
+MODULE_LICENSE("GPL v2");

total: 1 errors, 4 warnings, 2 checks, 139 lines checked




More information about the Intel-gfx mailing list