[Intel-gfx] [Intel-gfx 5/6] drm/i915/guc: Rename GuC log relay debugfs descriptively

Teres Alexis, Alan Previn alan.previn.teres.alexis at intel.com
Tue Dec 6 01:58:49 UTC 2022


> 
Alan:snip
> 

> >  void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> > @@ -204,7 +204,7 @@ void intel_guc_log_debugfs_register(struct intel_guc_log *log,
> > 		{ "guc_log_dump", &guc_log_dump_fops, NULL },
> > 		{ "guc_load_err_log_dump", &guc_load_err_log_dump_fops, NULL },
> > 		{ "guc_log_level", &guc_log_level_fops, NULL },
> > -		{ "guc_log_relay", &guc_log_relay_fops, NULL },
> > +		{ "guc_log_relay_ctl", &guc_log_relay_ctl_fops, NULL },
> 
> Even though debugfs, any issue with changing the file name from the uapi
> point of view? Any scripts etc. which will need to be updated?
> 
> 
Alan: Actually, relay logging tool in the IGT would need to change but upstream version of that tool has been broken for
a long while now nothing new can break on top of above change. I didnt see any other comments on this patch - let me
know if missed something else - as i will attempt to post this again tonight.



More information about the Intel-gfx mailing list