[Intel-gfx] [PATCH v6 2/3] drm/i915/selftests: use live_subtests for live_migrate

Andi Shyti andi.shyti at linux.intel.com
Tue Dec 6 16:01:07 UTC 2022


Hi Matt,

On Fri, Dec 02, 2022 at 12:28:43PM +0000, Matthew Auld wrote:
> Probably a good idea to do an igt_flush_test() at the end of each
> subtest, just to be sure the previous work has been flushed and doesn't
> somehow interfere with the current subtest.
> 
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Chris Wilson <chris.p.wilson at intel.com>
> Cc: Andi Shyti <andi.shyti at linux.intel.com>
> Cc: Andrzej Hajda <andrzej.hajda at intel.com>
> Cc: Nirmoy Das <nirmoy.das at intel.com>

[...]

> @@ -647,7 +661,7 @@ int intel_migrate_live_selftests(struct drm_i915_private *i915)
>  	if (!gt->migrate.context)
>  		return 0;
>  
> -	return i915_subtests(tests, &gt->migrate);
> +	return intel_gt_live_subtests(tests, gt);

yes... this calls the gt teardown function that waits for all the
works to end and yields to userspace signals... makes sense.

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

Thanks,
Andi


More information about the Intel-gfx mailing list