[Intel-gfx] [PATCH v6 3/3] drm/i915/selftests: exercise emit_pte() with nearly full ring

[Andi Shyti]

Hi Matt,

On Fri, Dec 02, 2022 at 12:28:44PM +0000, Matthew Auld wrote:
> Simple regression test to check that we don't trample the
> rq->reserved_space when returning from emit_pte(), if the ring is nearly
> full.
> 
> v2: Make spinner_kill() static
> v3: Reduce the ring size further, which should mean we need to execute less
>     noops; hopefully this appeases bsw. Also add some debug logging.
> v4: Fix the min request construction to account for reserved_space +
>     I915_EMIT_PTE_NUM_DWORDS
> v5: Use a simple on-stack timer to kill the spinner instead of kthread (Chris)
> 
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/7535
> References: https://gitlab.freedesktop.org/drm/intel/-/issues/6889
> Signed-off-by: Matthew Auld <matthew.auld at intel.com>
> Cc: Chris Wilson <chris.p.wilson at intel.com>
> Cc: Andi Shyti <andi.shyti at linux.intel.com>
> Cc: Andrzej Hajda <andrzej.hajda at intel.com>
> Cc: Nirmoy Das <nirmoy.das at intel.com>

Looks OK to me.

Reviewed-by: Andi Shyti <andi.shyti at linux.intel.com>

Andi