[Intel-gfx] [PATCH 2/2] drm/i915/dmc: Use unversioned firmware paths

Gustavo Sousa gustavo.sousa at intel.com
Wed Dec 21 15:08:36 UTC 2022


On Wed, Dec 21, 2022 at 12:26:26PM +0200, Jani Nikula wrote:
> > -	request_firmware(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> > +	err = firmware_request_nowarn(&fw, dev_priv->display.dmc.fw_path, dev_priv->drm.dev);
> > +
> > +	if (err == -ENOENT && !dev_priv->params.dmc_firmware_path) {
> > +		legacy_path = dmc_legacy_path(dev_priv);
> > +		if (legacy_path) {
> > +			drm_dbg_kms(&dev_priv->drm,
> > +				    "%s not found, falling back to %s\n",
> > +				    dmc->fw_path,
> > +				    legacy_path);
> > +			err = firmware_request_nowarn(&fw, legacy_path, dev_priv->drm.dev);
> > +			if (err == 0)
> > +				dev_priv->display.dmc.fw_path = legacy_path;
> > +		}
> > +	}
> > +
> 
> I'd keep the request_firmware() with warnings.

Thanks. Just sent a v2 with that.

--
Gustavo Sousa


More information about the Intel-gfx mailing list