[Intel-gfx] [PATCH 21/21] fbdev: Make registered_fb private to fbmem.c
daniel at ffwll.ch
Tue Feb 8 14:04:51 UTC 2022
On Fri, Feb 04, 2022 at 09:30:56AM +0100, Geert Uytterhoeven wrote:
> Hi Daniel,
> Thanks for your patch!
> On Tue, Feb 1, 2022 at 9:50 PM Daniel Vetter <daniel.vetter at ffwll.ch> wrote:
> > Well except when the olpc dcon fbdev driver is enabled, that thing
> > digs around in there in rather unfixable ways.
> Can't the actual frame buffer driver (which one?) used on olpc export
> a pointer to its fb_info?
Yeah that might be the right thing to do, I'll add that as a stagin TODO
in the next iteration.
> > --- a/drivers/video/fbdev/core/fbmem.c
> > +++ b/drivers/video/fbdev/core/fbmem.c
> > @@ -48,10 +48,14 @@
> > static DEFINE_MUTEX(registration_lock);
> > struct fb_info *registered_fb[FB_MAX] __read_mostly;
> > -EXPORT_SYMBOL(registered_fb);
> > -
> > int num_registered_fb __read_mostly;
> > +#if IS_ENABLED(CONFIG_OLPC_DCON)
> CONFIG_FB_OLPC_DCON (everywhere), cfr. the build failure reported
> by the robot.
Yeah realized that too and fixed it locally.
> Geert Uytterhoeven -- There's lots of Linux beyond ia32 -- geert at linux-m68k.org
> In personal conversations with technical people, I call myself a hacker. But
> when I'm talking to journalists I just say "programmer" or something like that.
> -- Linus Torvalds
Software Engineer, Intel Corporation
More information about the Intel-gfx