[Intel-gfx] [PATCH] drm/i915/dp: remove accidental static on what should be a local variable

Lucas De Marchi lucas.demarchi at intel.com
Thu Feb 17 08:52:43 UTC 2022


On Thu, Feb 17, 2022 at 10:39:38AM +0200, Jani Nikula wrote:
>The variable should obviously be local, not static.
>
>Fixes: a421d8a99216 ("drm/i915/dp: rewrite DP 2.0 128b/132b link training based on errata")
>Cc: Ville Syrjälä <ville.syrjala at linux.intel.com>
>Signed-off-by: Jani Nikula <jani.nikula at intel.com>


Reviewed-by: Lucas De Marchi <lucas.demarchi at intel.com>

Lucas De Marchi

>---
> drivers/gpu/drm/i915/display/intel_dp_link_training.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
>
>diff --git a/drivers/gpu/drm/i915/display/intel_dp_link_training.c b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>index 9197cc1734d2..5d98773efd1b 100644
>--- a/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>+++ b/drivers/gpu/drm/i915/display/intel_dp_link_training.c
>@@ -1408,7 +1408,7 @@ intel_dp_128b132b_link_train(struct intel_dp *intel_dp,
> void intel_dp_start_link_train(struct intel_dp *intel_dp,
> 			       const struct intel_crtc_state *crtc_state)
> {
>-	static bool passed;
>+	bool passed;
> 	/*
> 	 * TODO: Reiniting LTTPRs here won't be needed once proper connector
> 	 * HW state readout is added.
>-- 
>2.30.2
>


More information about the Intel-gfx mailing list