[Intel-gfx] [PATCH 2/2] drm/i915/dg2: Do not use phy E
jose.souza at intel.com
Fri Feb 18 16:54:34 UTC 2022
On Fri, 2022-02-18 at 01:54 -0800, Lucas De Marchi wrote:
> PORT_TC1 is still not being initialized - that is the port that uses phy
> E. However the intel_phy_is_snps() reports that phy as being present,
> which causes warnings about unclaimed access to the PHY_MISC register.
> Even with some basic wiring up for that port, it still gives the error:
> i915 0000:03:00.0: [drm] *ERROR* SNPS PHY E failed to calibrate after 25ms.
> So remove it for now.
Reviewed-by: José Roberto de Souza <jose.souza at intel.com>
> Signed-off-by: Lucas De Marchi <lucas.demarchi at intel.com>
> drivers/gpu/drm/i915/display/intel_display.c | 5 +++--
> 1 file changed, 3 insertions(+), 2 deletions(-)
> diff --git a/drivers/gpu/drm/i915/display/intel_display.c b/drivers/gpu/drm/i915/display/intel_display.c
> index 59961621fe4a..c3bb2da9e93a 100644
> --- a/drivers/gpu/drm/i915/display/intel_display.c
> +++ b/drivers/gpu/drm/i915/display/intel_display.c
> @@ -2148,9 +2148,10 @@ bool intel_phy_is_snps(struct drm_i915_private *dev_priv, enum phy phy)
> else if (IS_DG2(dev_priv))
> * All four "combo" ports and the TC1 port (PHY E) use
> - * Synopsis PHYs.
> + * Synopsis PHYs. However the last will only be used when
> + * PORT_TC1 is enabled.
> - return phy <= PHY_E;
> + return phy <= PHY_D;
> return false;
More information about the Intel-gfx