[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for DGFX OpRegion (rev3)

Patchwork patchwork at emeril.freedesktop.org
Sun Feb 20 17:00:31 UTC 2022


== Series Details ==

Series: DGFX OpRegion (rev3)
URL   : https://patchwork.freedesktop.org/series/99738/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
c0905817ebdb drm/i915/opregion: Add intel_opregion_init() wrapper
a90a3f2681d0 drm/i915/opregion: Abstract opregion function
-:214: ERROR:SPACING: space required before the open parenthesis '('
#214: FILE: drivers/gpu/drm/i915/display/intel_opregion.c:1265:
+	if(drm_WARN_ON(&i915->drm, !opregion->asls || !opregion->header))

total: 1 errors, 0 warnings, 0 checks, 254 lines checked
746dd2f8a0c1 drm/i915/opregion: Add dgfx opregion func
35de4da7ebcd drm/i915/opregion: Cond dgfx opregion func registration
90ff2a12e00a drm/i915/dgfx: OPROM OpRegion Setup
-:235: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*exprom_hdr)...) over kzalloc(sizeof(struct expansion_rom_header)...)
#235: FILE: drivers/gpu/drm/i915/display/intel_opregion.c:1046:
+	exprom_hdr = kzalloc(sizeof(struct expansion_rom_header), GFP_KERNEL);

-:236: CHECK:ALLOC_SIZEOF_STRUCT: Prefer kzalloc(sizeof(*exprom_pci_data)...) over kzalloc(sizeof(struct pci_data_structure)...)
#236: FILE: drivers/gpu/drm/i915/display/intel_opregion.c:1047:
+	exprom_pci_data = kzalloc(sizeof(struct pci_data_structure), GFP_KERNEL);

total: 0 errors, 0 warnings, 2 checks, 413 lines checked
06b60e64062b drm/i915/dgfx: Get VBT from rvda




More information about the Intel-gfx mailing list