[Intel-gfx] [PATCH 1/2] drm/i915: Fix assert in i915_ggtt_pin

Tvrtko Ursulin tvrtko.ursulin at linux.intel.com
Fri Feb 25 17:41:17 UTC 2022

From: Tvrtko Ursulin <tvrtko.ursulin at intel.com>

Use lockdep_assert_not_held to simplify and correct the code. Otherwise
false positive are hit if lock state is uknown like after a previous

Signed-off-by: Tvrtko Ursulin <tvrtko.ursulin at intel.com>
Reported-by: Ville Syrjälä <ville.syrjala at linux.intel.com>
 drivers/gpu/drm/i915/i915_vma.c | 4 +---
 1 file changed, 1 insertion(+), 3 deletions(-)

diff --git a/drivers/gpu/drm/i915/i915_vma.c b/drivers/gpu/drm/i915/i915_vma.c
index 3558b16a929c..4469b7f52853 100644
--- a/drivers/gpu/drm/i915/i915_vma.c
+++ b/drivers/gpu/drm/i915/i915_vma.c
@@ -1552,9 +1552,7 @@ int i915_ggtt_pin(struct i915_vma *vma, struct i915_gem_ww_ctx *ww,
 	if (ww)
 		return __i915_ggtt_pin(vma, ww, align, flags);
-	WARN_ON(dma_resv_held(vma->obj->base.resv));
+	lockdep_assert_not_held(&vma->obj->base.resv->lock.base);
 	for_i915_gem_ww(&_ww, err, true) {
 		err = i915_gem_object_lock(vma->obj, &_ww);

More information about the Intel-gfx mailing list