[Intel-gfx] ✗ Fi.CI.CHECKPATCH: warning for drm/i915: Recalculate CDCLK if plane scaling ratio changes

Patchwork patchwork at emeril.freedesktop.org
Tue Jan 11 18:39:11 UTC 2022


== Series Details ==

Series: drm/i915: Recalculate CDCLK if plane scaling ratio changes
URL   : https://patchwork.freedesktop.org/series/98750/
State : warning

== Summary ==

$ dim checkpatch origin/drm-tip
fe1ac4423d86 drm/i915: Recalculate CDCLK if plane scaling ratio changes
-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_hscale_ratio != new_hscale_ratio'
#61: FILE: drivers/gpu/drm/i915/display/intel_display.c:7540:
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {

-:61: CHECK:UNNECESSARY_PARENTHESES: Unnecessary parentheses around 'old_vscale_ratio != new_vscale_ratio'
#61: FILE: drivers/gpu/drm/i915/display/intel_display.c:7540:
+	if ((old_hscale_ratio != new_hscale_ratio) ||
+	    (old_vscale_ratio != new_vscale_ratio)) {

-:116: WARNING:LONG_LINE: line length of 101 exceeds 100 columns
#116: FILE: drivers/gpu/drm/i915/display/intel_display.c:7603:
+		if ((hweight8(old_active_planes) == hweight8(new_active_planes)) && !need_cdclk_calc)

-:123: CHECK:LINE_SPACING: Please don't use multiple blank lines
#123: FILE: drivers/gpu/drm/i915/display/intel_display.c:7610:
+
+

total: 0 errors, 1 warnings, 3 checks, 104 lines checked




More information about the Intel-gfx mailing list